Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34922 )
Change subject: arch/non-x86: Drop spurious #if ENV_RAMSTAGE ......................................................................
arch/non-x86: Drop spurious #if ENV_RAMSTAGE
Change-Id: If4164836dfa419e26badf0880ce40e2fe184cd6c Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/cpu/ti/am335x/uart.c M src/drivers/uart/pl011.c M src/drivers/uart/sifive.c M src/mainboard/emulation/qemu-power8/uart.c M src/soc/imgtec/pistachio/uart.c M src/soc/mediatek/common/uart.c M src/soc/nvidia/tegra124/uart.c M src/soc/nvidia/tegra210/uart.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/ipq806x/uart.c M src/soc/qualcomm/qcs405/uart.c M src/soc/samsung/exynos5250/uart.c M src/soc/samsung/exynos5420/uart.c 13 files changed, 0 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/34922/1
diff --git a/src/cpu/ti/am335x/uart.c b/src/cpu/ti/am335x/uart.c index f42b946..f0e6f2f 100644 --- a/src/cpu/ti/am335x/uart.c +++ b/src/cpu/ti/am335x/uart.c @@ -182,7 +182,6 @@ { }
-#if ENV_RAMSTAGE void uart_fill_lb(void *data) { struct lb_serial serial; @@ -194,4 +193,3 @@
lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, data); } -#endif diff --git a/src/drivers/uart/pl011.c b/src/drivers/uart/pl011.c index 1764f15..ad00d7c 100644 --- a/src/drivers/uart/pl011.c +++ b/src/drivers/uart/pl011.c @@ -49,7 +49,6 @@ return read8(®s->dr); }
-#if ENV_RAMSTAGE void uart_fill_lb(void *data) { struct lb_serial serial; @@ -63,4 +62,3 @@
lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, data); } -#endif diff --git a/src/drivers/uart/sifive.c b/src/drivers/uart/sifive.c index 9ca669a..ca8b73b 100644 --- a/src/drivers/uart/sifive.c +++ b/src/drivers/uart/sifive.c @@ -113,9 +113,7 @@ return 1; }
-#if ENV_RAMSTAGE void uart_fill_lb(void *data) { /* TODO */ } -#endif diff --git a/src/mainboard/emulation/qemu-power8/uart.c b/src/mainboard/emulation/qemu-power8/uart.c index 76c8afc..7c77971 100644 --- a/src/mainboard/emulation/qemu-power8/uart.c +++ b/src/mainboard/emulation/qemu-power8/uart.c @@ -41,7 +41,6 @@ { }
-#if ENV_RAMSTAGE void uart_fill_lb(void *data) { struct lb_serial serial; @@ -53,4 +52,3 @@ lb_add_serial(&serial, data); lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, data); } -#endif diff --git a/src/soc/imgtec/pistachio/uart.c b/src/soc/imgtec/pistachio/uart.c index 9d15237..3afd555 100644 --- a/src/soc/imgtec/pistachio/uart.c +++ b/src/soc/imgtec/pistachio/uart.c @@ -143,7 +143,6 @@ uart8250_mem_tx_flush(CONFIG_CONSOLE_SERIAL_UART_ADDRESS); }
-#if ENV_RAMSTAGE void uart_fill_lb(void *data) { struct lb_serial serial; @@ -155,4 +154,3 @@
lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, data); } -#endif diff --git a/src/soc/mediatek/common/uart.c b/src/soc/mediatek/common/uart.c index c1b4616..d4a052f 100644 --- a/src/soc/mediatek/common/uart.c +++ b/src/soc/mediatek/common/uart.c @@ -172,7 +172,6 @@ mtk_uart_tx_flush(); }
-#if ENV_RAMSTAGE void uart_fill_lb(void *data) { struct lb_serial serial; @@ -185,4 +184,3 @@
lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, data); } -#endif diff --git a/src/soc/nvidia/tegra124/uart.c b/src/soc/nvidia/tegra124/uart.c index 923fdd7..b1989dd 100644 --- a/src/soc/nvidia/tegra124/uart.c +++ b/src/soc/nvidia/tegra124/uart.c @@ -128,7 +128,6 @@ tegra124_uart_tx_flush(uart_ptr); }
-#if ENV_RAMSTAGE void uart_fill_lb(void *data) { struct lb_serial serial; @@ -140,4 +139,3 @@
lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, data); } -#endif diff --git a/src/soc/nvidia/tegra210/uart.c b/src/soc/nvidia/tegra210/uart.c index 3d8e53e..459cf74 100644 --- a/src/soc/nvidia/tegra210/uart.c +++ b/src/soc/nvidia/tegra210/uart.c @@ -115,7 +115,6 @@ return tegra210_uart_rx_byte(); }
-#if ENV_RAMSTAGE void uart_fill_lb(void *data) { struct lb_serial serial; @@ -127,4 +126,3 @@
lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, data); } -#endif diff --git a/src/soc/qualcomm/ipq40xx/uart.c b/src/soc/qualcomm/ipq40xx/uart.c index 6d3b72a..95e2eab 100644 --- a/src/soc/qualcomm/ipq40xx/uart.c +++ b/src/soc/qualcomm/ipq40xx/uart.c @@ -283,7 +283,6 @@ return byte; }
-#if ENV_RAMSTAGE /* TODO: Implement function */ void uart_fill_lb(void *data) { @@ -297,4 +296,3 @@ lb_add_serial(&serial, data); lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, data); } -#endif diff --git a/src/soc/qualcomm/ipq806x/uart.c b/src/soc/qualcomm/ipq806x/uart.c index 7b70283..f3e7de5 100644 --- a/src/soc/qualcomm/ipq806x/uart.c +++ b/src/soc/qualcomm/ipq806x/uart.c @@ -398,9 +398,7 @@ return byte; }
-#if ENV_RAMSTAGE /* TODO: Implement fuction */ void uart_fill_lb(void *data) { } -#endif diff --git a/src/soc/qualcomm/qcs405/uart.c b/src/soc/qualcomm/qcs405/uart.c index d7e3bcd..6f95ba4 100644 --- a/src/soc/qualcomm/qcs405/uart.c +++ b/src/soc/qualcomm/qcs405/uart.c @@ -287,7 +287,6 @@ } #endif
-#if ENV_RAMSTAGE void uart_fill_lb(void *data) { struct lb_serial serial; @@ -300,4 +299,3 @@ lb_add_serial(&serial, data); lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, data); } -#endif diff --git a/src/soc/samsung/exynos5250/uart.c b/src/soc/samsung/exynos5250/uart.c index f2b4d82..53290cf 100644 --- a/src/soc/samsung/exynos5250/uart.c +++ b/src/soc/samsung/exynos5250/uart.c @@ -185,7 +185,6 @@ exynos5_uart_tx_flush(uart); }
-#if ENV_RAMSTAGE void uart_fill_lb(void *data) { struct lb_serial serial; @@ -197,4 +196,3 @@
lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, data); } -#endif diff --git a/src/soc/samsung/exynos5420/uart.c b/src/soc/samsung/exynos5420/uart.c index 9c78075..41fdd0d 100644 --- a/src/soc/samsung/exynos5420/uart.c +++ b/src/soc/samsung/exynos5420/uart.c @@ -176,7 +176,6 @@ /* Exynos5250 implements this too. */ }
-#if ENV_RAMSTAGE void uart_fill_lb(void *data) { struct lb_serial serial; @@ -190,4 +189,3 @@
lb_add_console(LB_TAG_CONSOLE_SERIAL8250MEM, data); } -#endif
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34922 )
Change subject: arch/non-x86: Drop spurious #if ENV_RAMSTAGE ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34922 )
Change subject: arch/non-x86: Drop spurious #if ENV_RAMSTAGE ......................................................................
Patch Set 2: Code-Review-1
Going to squash this with parent. Preceding commit would suggest !__PRE_RAM__ => ENV_RAMSTAGE transition would be fine, but we seem to agree that it is only half the picture.
Hello ron minnich, Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34922
to look at the new patch set (#3).
Change subject: arch/non-x86: Drop spurious uses of #if !__PRE_RAM__ ......................................................................
arch/non-x86: Drop spurious uses of #if !__PRE_RAM__
Change-Id: If4164836dfa419e26badf0880ce40e2fe184cd6c Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/cpu/ti/am335x/uart.c M src/drivers/uart/pl011.c M src/drivers/uart/sifive.c M src/mainboard/emulation/qemu-power8/uart.c M src/soc/imgtec/pistachio/uart.c M src/soc/mediatek/common/uart.c M src/soc/nvidia/tegra124/uart.c M src/soc/nvidia/tegra210/uart.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/ipq806x/uart.c M src/soc/qualcomm/qcs405/uart.c M src/soc/samsung/exynos5250/uart.c M src/soc/samsung/exynos5420/uart.c 13 files changed, 0 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/34922/3
Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34922 )
Change subject: arch/non-x86: Drop spurious uses of #if !__PRE_RAM__ ......................................................................
Abandoned
squashed with CB:34921
-
Julius Werner (Code Review) -
Kyösti Mälkki (Code Review)