Attention is currently required from: Jeff Daly, Sean Rhodes, Vanessa Eusebio, Kyösti Mälkki.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70050 )
Change subject: soc/intel: Adopt new common/pmbase
......................................................................
Patch Set 6:
(1 comment)
File src/southbridge/intel/common/pmbase.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-165057):
https://review.coreboot.org/c/coreboot/+/70050/comment/09156602_5298c7dd
PS6, Line 11: CONFIG(SOC_INTEL_BROADWELL) || CONFIG(SOC_INTEL_DENVERTON_NS)
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70050
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I473ebefcf8e0c929f6cbf6b5c0d7e8f5af72856d
Gerrit-Change-Number: 70050
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 02 Dec 2022 07:53:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment