Attention is currently required from: Bora Guvendik, Cliff Huang, Selma Bensaid, Paul Menzel. Hello Bora Guvendik, build bot (Jenkins), Selma Bensaid, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61887
to look at the new patch set (#14).
Change subject: mb/google/brya: Move ACPI MPTS method from DSDT to SSDT for Brya and Redrix ......................................................................
mb/google/brya: Move ACPI MPTS method from DSDT to SSDT for Brya and Redrix
This change is to move MPTS (Mainboard Prepare To Sleep) method from wwan_power.asl to SSDT.
MPTS is mainboard-specific method, while wwan_power.asl is meant for WWAN from its name.
Having fixed MPTS method (i.e. DSDT) can not cover the case where device only presents and certain CBI bit(s) is(are) set.
In Redrix and Brya, there are SKUs with or without 5G, 4G device. For those with 4G, MPTS method should be different. For those with no WWAN device, no MPTS is needed.
Having MPTS generating in SSDT also eliminates the need for introducing Kconfig flags to support different devices in the future. MPTS method is created inside mainboard_fill_ssdt function in which the corresponding variant function is called.
This will generate the following for the mainboard: Scope (_SB) { Method (MPTS, 1, Serialized) { Local0 = _SB.PCI0.RP01.RTD3._STA () If ((Local0 == One)) { _SB.PCI0.RP01.PXSX.DPTS (Arg0) } } }
Test: Check the SSDT for MPTS method under _SB after boot to OS Use shutdown command and check the GPIO pins from logical analyzer
Signed-off-by: Cliff Huang cliff.huang@intel.com Change-Id: I0f0b7638e90a7862173fca99305398bb250373e9 --- M src/mainboard/google/brya/Kconfig.name M src/mainboard/google/brya/mainboard.c M src/mainboard/google/brya/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/brya/variants/brya0/overridetree.cb M src/mainboard/google/brya/variants/brya4es/overridetree.cb M src/mainboard/google/brya/variants/redrix/overridetree.cb M src/mainboard/google/brya/variants/redrix4es/overridetree.cb 7 files changed, 66 insertions(+), 23 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/61887/14