Change in coreboot[master]: Documentation: Add proposal for a comprehensive image assembly stage
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32687 )
Change subject: Documentation: Add proposal for a comprehensive image assembly stage ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
LGTM. The more visible it is, the more likely someone wants to work on it.
https://review.coreboot.org/c/coreboot/+/32687/1/Documentation/technotes/201... File Documentation/technotes/2015-11-rebuilding-coreboot-image-generation.md:
https://review.coreboot.org/c/coreboot/+/32687/1/Documentation/technotes/201... PS1, Line 186: coreboot manifest
Would cbfsfile alignment also be handled here?
Ack
https://review.coreboot.org/c/coreboot/+/32687/1/Documentation/technotes/201... PS1, Line 194: group ramstage: build/dsdt.aml compression=lzma
might be a good idea on to add to the example on how the bootblock is handled.
Ack
https://review.coreboot.org/c/coreboot/+/32687/1/Documentation/technotes/201... PS1, Line 196: boot method manifest
maybe add in this example where the FMAP FMAP region ends up and how region can be aligned (needed f […]
Ack
-
Arthur Heymans (Code Review)