Change in coreboot[master]: Revert "mb/google/zork/dalboz: Increase eMMC initial clock frequency"
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/45004
to review the following change.
Change subject: Revert "mb/google/zork/dalboz: Increase eMMC initial clock frequency" ......................................................................
Revert "mb/google/zork/dalboz: Increase eMMC initial clock frequency"
This reverts commit c4a5acdabc28778b49a1c088b0736bac83e2ab51.
Reason for revert: Dalboz is missing pull-up on cmd line, so 400khz is not possible.
Change-Id: I89653bfeefa522c17ee2d736215bc22aa445871c --- M src/mainboard/google/zork/variants/dalboz/overridetree.cb 1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/45004/1
diff --git a/src/mainboard/google/zork/variants/dalboz/overridetree.cb b/src/mainboard/google/zork/variants/dalboz/overridetree.cb index e5608d9..1ddb17b 100644 --- a/src/mainboard/google/zork/variants/dalboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/dalboz/overridetree.cb @@ -37,12 +37,6 @@ .early_init = true, }"
- register "emmc_config" = "{ - .timing = SD_EMMC_EMMC_HS400, - .sdr104_hs400_driver_strength = SD_EMMC_DRIVE_STRENGTH_A, - .init_khz_preset = 400, - }" - # See AMD 55570-B1 Table 13: PCI Device ID Assignments. device domain 0 on subsystemid 0x1022 0x1510 inherit
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45004
to look at the new patch set (#2).
Change subject: Revert "mb/google/zork/dalboz: Increase eMMC initial clock frequency" ......................................................................
Revert "mb/google/zork/dalboz: Increase eMMC initial clock frequency"
This reverts commit c4a5acdabc28778b49a1c088b0736bac83e2ab51.
Reason for revert: Dalboz is missing pull-up on cmd line, so 400khz is not possible.
TEST=Boot Dalboz BUG=b:159823235 BRANCH=zork
Change-Id: I89653bfeefa522c17ee2d736215bc22aa445871c --- M src/mainboard/google/zork/variants/dalboz/overridetree.cb 1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/45004/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45004
to look at the new patch set (#3).
Change subject: Revert "mb/google/zork/dalboz: Increase eMMC initial clock frequency" ......................................................................
Revert "mb/google/zork/dalboz: Increase eMMC initial clock frequency"
This reverts commit c4a5acdabc28778b49a1c088b0736bac83e2ab51.
Reason for revert: Dalboz is missing pull-up on cmd line, so 400khz is not possible.
TEST=Boot Dalboz BUG=b:159823235, b:169940175 BRANCH=zork
Change-Id: I89653bfeefa522c17ee2d736215bc22aa445871c --- M src/mainboard/google/zork/variants/dalboz/overridetree.cb 1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/45004/3
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45004 )
Change subject: Revert "mb/google/zork/dalboz: Increase eMMC initial clock frequency" ......................................................................
Patch Set 3: Code-Review+2
Hello build bot (Jenkins), Martin Roth, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45004
to look at the new patch set (#4).
Change subject: Revert "mb/google/zork/dalboz: Increase eMMC initial clock frequency" ......................................................................
Revert "mb/google/zork/dalboz: Increase eMMC initial clock frequency"
This reverts commit c4a5acdabc28778b49a1c088b0736bac83e2ab51.
Reason for revert: Dalboz is missing pull-up on cmd line, so 400khz is not possible.
TEST=Boot Dalboz BUG=b:159823235, b:169940175 BRANCH=zork
Change-Id: I89653bfeefa522c17ee2d736215bc22aa445871c Signed-off-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/zork/variants/dalboz/overridetree.cb 1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/45004/4
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45004 )
Change subject: Revert "mb/google/zork/dalboz: Increase eMMC initial clock frequency" ......................................................................
Revert "mb/google/zork/dalboz: Increase eMMC initial clock frequency"
This reverts commit c4a5acdabc28778b49a1c088b0736bac83e2ab51.
Reason for revert: Dalboz is missing pull-up on cmd line, so 400khz is not possible.
TEST=Boot Dalboz BUG=b:159823235, b:169940175 BRANCH=zork
Change-Id: I89653bfeefa522c17ee2d736215bc22aa445871c Signed-off-by: Rob Barnes robbarnes@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45004 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/mainboard/google/zork/variants/dalboz/overridetree.cb 1 file changed, 0 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/dalboz/overridetree.cb b/src/mainboard/google/zork/variants/dalboz/overridetree.cb index e5608d9..1ddb17b 100644 --- a/src/mainboard/google/zork/variants/dalboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/dalboz/overridetree.cb @@ -37,12 +37,6 @@ .early_init = true, }"
- register "emmc_config" = "{ - .timing = SD_EMMC_EMMC_HS400, - .sdr104_hs400_driver_strength = SD_EMMC_DRIVE_STRENGTH_A, - .init_khz_preset = 400, - }" - # See AMD 55570-B1 Table 13: PCI Device ID Assignments. device domain 0 on subsystemid 0x1022 0x1510 inherit
-
Martin Roth (Code Review) -
Patrick Georgi (Code Review)
-
Rob Barnes (Code Review)