Attention is currently required from: Sean Rhodes, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57140 )
Change subject: soc/tigerlake: Make IO decode / enable register configurable
......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/tigerlake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/57140/comment/b748c39d_33b96750
PS4, Line 30: #include "../chip.h"
`#include <soc/soc_chip.h>`
https://review.coreboot.org/c/coreboot/+/57140/comment/14748b7a_60a8824b
PS4, Line 115: 0x3f0f
what is this supposed to represent?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57140
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1a7f2707e565a5651ebe438320de9597f5742c3
Gerrit-Change-Number: 57140
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
admin@starlabs.systems
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 25 Aug 2021 17:23:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment