[S] Change in libhwbase[master]: hw-debug: Ensure global variable default are zeros and in .bss - coreboot-gerrit

2 Dec 2022


      Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/libhwbase/+/69854 )
Change subject: hw-debug: Ensure global variable default are zeros and in .bss
......................................................................
Patch Set 1:
(1 comment)
File debug/hw-debug.adb:
https://review.coreboot.org/c/libhwbase/+/69854/comment/4fafe753_f116b2e5 
PS1, Line 26:    Not_Start_Of_Line : Boolean;
@Nico and @Angel,
I am considering a few things:
1. renaming `Not_Start_Of_Line` with `Middle_Of_Line`
2. Add both `hw__debug__middle_of_line` and `hw__debug__register_write_delay_nanoseconds` in https://review.coreboot.org/c/coreboot/+/70276/2/src/arch/x86/car.ld#76
What do you think ?
-- 
To view, visit https://review.coreboot.org/c/libhwbase/+/69854
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: libhwbase
Gerrit-Branch: master
Gerrit-Change-Id: Ib23699f3f3446219c34c60ccd9987346e17769f2
Gerrit-Change-Number: 69854
Gerrit-PatchSet: 1
Gerrit-Owner: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Tarun Tuli taruntuli@google.com
Gerrit-Comment-Date: Fri, 02 Dec 2022 22:52:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment