Maulik V Vaghela has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30678
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
mb/google/hatch: Enable support for WWAN
This patch enables relevant GPIOs to enable WWAN. WWAN also requires to enable USB 2 port 6 and USB3 port 5 which is already enabled in device tree related changes.
BUG=b:120914069 BRANCH=none TEST=check if code compiles with changes.
Change-Id: I1559bbc6168aec1a369bf3291d2c1e2f9a2fbe07 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/30678/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index d40c020..5c0231e 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -23,6 +23,10 @@ PAD_NC(GPP_A16, DN_20K), /* EN_PP3300_SD_DX */ PAD_CFG_NF(GPP_A17, NONE, DEEP, NF1), + /* EN_PP3300_WWAN */ + PAD_CFG_GPO(GPP_A18, 1, DEEP), + /* WWAN_RADIO_DISABLE_1V8_ODL */ + PAD_CFG_GPO(GPP_A19, 0, DEEP), /* TRACKPAD_INT_ODL */ PAD_CFG_GPI_APIC(GPP_A21, NONE, PLTRST, LEVEL, INVERT), /* SRCCLKREQ1 */ @@ -47,6 +51,8 @@ PAD_NC(GPP_C11, DN_20K), /* BT_DISABLE_L */ PAD_CFG_GPO(GPP_C14, 1, DEEP), + /* WWAN_DPR_SAR_ODL */ + PAD_CFG_GPO(GPP_C15, 0, DEEP), /* PCH_I2C_TRACKPAD_SDA */ PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), /* PCH_I2C_TRACKPAD_SCL */ @@ -63,6 +69,14 @@ PAD_CFG_GPI(GPP_C22, NONE, DEEP), /* WLAN_PE_RST# */ PAD_CFG_GPO(GPP_C23, 1, DEEP), + /* WWAN_CONFIG_0 */ + PAD_CFG_GPI(GPP_D5, NONE, DEEP), + /* WWAN_CONFIG_1 */ + PAD_CFG_GPI(GPP_D6, NONE, DEEP), + /* WWAN_CONFIG_2 */ + PAD_CFG_GPI(GPP_D7, NONE, DEEP), + /* WWAN_CONFIG_3 */ + PAD_CFG_GPI(GPP_D8, NONE, DEEP), /* TOUCHSCREEN_RST_L */ PAD_CFG_GPO(GPP_D15, 0, DEEP), /* TOUCHSCREEN_INT_L */ @@ -95,6 +109,8 @@ PAD_NC(GPP_E22, DN_20K), /* GPIO_WWAN_WLAN_COEX3 */ PAD_CFG_NF(GPP_F0, NONE, DEEP, NF1), + /* WWAN_RESET_1V8_ODL */ + PAD_CFG_GPO(GPP_F1, 0, DEEP), /* UART_WWANTX_WLANRX_COEX1 */ PAD_CFG_NF(GPP_F8, NONE, DEEP, NF1), /* UART_WWANRX_WLANTX_COEX2 */
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30678 )
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/30678/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/30678/1/src/mainboard/google/hatch/variants/... PS1, Line 29: 0
Yes, This is active low signal. […]
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30678 )
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... PS7, Line 55: 0 Is this the right value for this GPIO?
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... PS7, Line 72: /* WWAN_CONFIG_0 */ : PAD_CFG_GPI(GPP_D5, NONE, DEEP), : /* WWAN_CONFIG_1 */ : PAD_CFG_GPI(GPP_D6, NONE, DEEP), : /* WWAN_CONFIG_2 */ : PAD_CFG_GPI(GPP_D7, NONE, DEEP), : /* WWAN_CONFIG_3 */ : PAD_CFG_GPI(GPP_D8, NONE, DEEP), Since we are not yet sure how or if this will be used, let's just configure it as NC.
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... PS7, Line 113: 0 1?
Hello Naresh Solanki, Subrata Banik, Balaji Manigandan, Ronak Kanabar, Aamir Bohra, Rizwan Qureshi, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30678
to look at the new patch set (#8).
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
mb/google/hatch: Enable support for WWAN
This patch enables relevant GPIOs to enable WWAN. WWAN also requires to enable USB 2 port 6 and USB3 port 5 which is already enabled in device tree related changes.
BUG=b:120914069 BRANCH=none TEST=check if code compiles with changes.
Change-Id: I1559bbc6168aec1a369bf3291d2c1e2f9a2fbe07 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/30678/8
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30678 )
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... PS7, Line 55: 0
Is this the right value for this GPIO?
This GPIO goes to DPR pin of WWAN module. This is active low pin and if we make it 0, it enabled Dynamic Power Reduction(DPR) for WWAN based on proximity sensor inputs. I am changing it to 1, so we don't enable DPR by default and it can be handled by driver.
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... PS7, Line 72: /* WWAN_CONFIG_0 */ : PAD_CFG_GPI(GPP_D5, NONE, DEEP), : /* WWAN_CONFIG_1 */ : PAD_CFG_GPI(GPP_D6, NONE, DEEP), : /* WWAN_CONFIG_2 */ : PAD_CFG_GPI(GPP_D7, NONE, DEEP), : /* WWAN_CONFIG_3 */ : PAD_CFG_GPI(GPP_D8, NONE, DEEP),
Since we are not yet sure how or if this will be used, let's just configure it as NC.
Done
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... PS7, Line 113: 0
1?
Done
Hello Naresh Solanki, Subrata Banik, Balaji Manigandan, Ronak Kanabar, Aamir Bohra, Rizwan Qureshi, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30678
to look at the new patch set (#9).
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
mb/google/hatch: Enable support for WWAN
This patch enables relevant GPIOs to enable WWAN. WWAN also requires to enable USB 2 port 6 and USB3 port 5 which is already enabled in device tree related changes.
BUG=b:120914069 BRANCH=none TEST=check if code compiles with changes.
Change-Id: I1559bbc6168aec1a369bf3291d2c1e2f9a2fbe07 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/30678/9
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30678 )
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... PS7, Line 55: 0
This GPIO goes to DPR pin of WWAN module. […]
How is the driver aware of this pin?
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30678 )
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/30678/7/src/mainboard/google/hatch/variants/... PS7, Line 55: 0
How is the driver aware of this pin?
Currently WWAN driver is not using this GPIO, so we are not exposing it. We're just disabling DPR by default.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30678 )
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/30678/10/src/mainboard/google/hatch/variants... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/30678/10/src/mainboard/google/hatch/variants... PS10, Line 109: extra space not required.
Hello Naresh Solanki, Subrata Banik, Balaji Manigandan, Ronak Kanabar, Aamir Bohra, Rizwan Qureshi, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30678
to look at the new patch set (#11).
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
mb/google/hatch: Enable support for WWAN
This patch enables relevant GPIOs to enable WWAN. WWAN also requires to enable USB 2 port 6 and USB3 port 5 which is already enabled in device tree related changes.
BUG=b:120914069 BRANCH=none TEST=check if code compiles with changes.
Change-Id: I1559bbc6168aec1a369bf3291d2c1e2f9a2fbe07 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/30678/11
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30678 )
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/#/c/30678/10/src/mainboard/google/hatch/variants... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/30678/10/src/mainboard/google/hatch/variants... PS10, Line 109:
extra space not required.
Done
Hello Naresh Solanki, Subrata Banik, Balaji Manigandan, Ronak Kanabar, Aamir Bohra, Rizwan Qureshi, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30678
to look at the new patch set (#12).
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
mb/google/hatch: Enable support for WWAN
This patch enables relevant GPIOs to enable WWAN. WWAN also requires to enable USB 2 port 6 and USB3 port 5 which is already enabled in device tree related changes.
BUG=b:120914069 BRANCH=none TEST=check if code compiles with changes.
Change-Id: I1559bbc6168aec1a369bf3291d2c1e2f9a2fbe07 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/30678/12
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30678 )
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
Patch Set 12: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30678 )
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
Patch Set 12: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30678 )
Change subject: mb/google/hatch: Enable support for WWAN ......................................................................
mb/google/hatch: Enable support for WWAN
This patch enables relevant GPIOs to enable WWAN. WWAN also requires to enable USB 2 port 6 and USB3 port 5 which is already enabled in device tree related changes.
BUG=b:120914069 BRANCH=none TEST=check if code compiles with changes.
Change-Id: I1559bbc6168aec1a369bf3291d2c1e2f9a2fbe07 Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-on: https://review.coreboot.org/c/30678 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Rizwan Qureshi rizwan.qureshi@intel.com Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 20 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Rizwan Qureshi: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 3e73d95..ade9ed2 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -23,6 +23,10 @@ PAD_NC(GPP_A16, DN_20K), /* EN_PP3300_SD_DX */ PAD_CFG_NF(GPP_A17, NONE, DEEP, NF1), + /* EN_PP3300_WWAN */ + PAD_CFG_GPO(GPP_A18, 1, DEEP), + /* WWAN_RADIO_DISABLE_1V8_ODL */ + PAD_CFG_GPO(GPP_A19, 1, DEEP), /* TRACKPAD_INT_ODL */ PAD_CFG_GPI_APIC(GPP_A21, NONE, PLTRST, LEVEL, INVERT), /* SRCCLKREQ1 */ @@ -47,6 +51,12 @@ PAD_NC(GPP_C11, DN_20K), /* BT_DISABLE_L */ PAD_CFG_GPO(GPP_C14, 1, DEEP), + /* WWAN_DPR_SAR_ODL + * + * TODO: Driver doesn't use this pin as of now. In case driver starts + * using this pin, expose this pin to driver. + */ + PAD_CFG_GPO(GPP_C15, 1, DEEP), /* PCH_I2C_TRACKPAD_SDA */ PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), /* PCH_I2C_TRACKPAD_SCL */ @@ -63,6 +73,14 @@ PAD_CFG_GPI(GPP_C22, NONE, DEEP), /* WLAN_PE_RST# */ PAD_CFG_GPO(GPP_C23, 1, DEEP), + /* WWAN_CONFIG_0 */ + PAD_NC(GPP_D5, NONE), + /* WWAN_CONFIG_1 */ + PAD_NC(GPP_D6, NONE), + /* WWAN_CONFIG_2 */ + PAD_NC(GPP_D7, NONE), + /* WWAN_CONFIG_3 */ + PAD_NC(GPP_D8, NONE), /* TOUCHSCREEN_RST_L */ PAD_CFG_GPO(GPP_D15, 0, DEEP), /* TOUCHSCREEN_INT_L */ @@ -95,6 +113,8 @@ PAD_NC(GPP_E22, DN_20K), /* GPIO_WWAN_WLAN_COEX3 */ PAD_CFG_NF(GPP_F0, NONE, DEEP, NF1), + /* WWAN_RESET_1V8_ODL */ + PAD_CFG_GPO(GPP_F1, 1, DEEP), /* UART_WWANTX_WLANRX_COEX1 */ PAD_CFG_NF(GPP_F8, NONE, DEEP, NF1), /* UART_WWANRX_WLANTX_COEX2 */
-
Furquan Shaikh (Code Review) -
Maulik V Vaghela (Code Review)
-
Patrick Georgi (Code Review)
-
Rizwan Qureshi (Code Review)