Change in coreboot[master]: soc/intel/cmn/gpmr: Enhance GPMR driver - coreboot-gerrit

13 Apr 2022


      Attention is currently required from: Wonkyu Kim, Subrata Banik, Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Michael Niewöhner.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63607 )
Change subject: soc/intel/cmn/gpmr: Enhance GPMR driver
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/gpmr/gpmr.c:
https://review.coreboot.org/c/coreboot/+/63607/comment/8f5f68f2_75a66b30 
PS1, Line 9: #define MAX_GPMR_REGS				3
...
...
those define is the same in pcr_gpmr.h. Maybe you can move into gpmr.h and include it in pcr_gpmr. […]
yes, I saw the following patch.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63607
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87dca55a068366cb9a26a5218589166c1723da7f
Gerrit-Change-Number: 63607
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Comment-Date: Wed, 13 Apr 2022 08:19:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment