Attention is currently required from: Marshall Dawson, Kyösti Mälkki, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63387 )
Change subject: drivers/usb/pci_ehci.c: Move away from __SIMPLE_DEVICE__ ......................................................................
Patch Set 1:
(4 comments)
File src/drivers/usb/pci_ehci.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145473): https://review.coreboot.org/c/coreboot/+/63387/comment/9bb9e8e4_2093db0c PS1, Line 91: const struct device *dbg_dev = pci_ehci_dbg_dev(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145473): https://review.coreboot.org/c/coreboot/+/63387/comment/4774ce42_cf165bc0 PS1, Line 91: const struct device *dbg_dev = pci_ehci_dbg_dev(); please, no spaces at the start of a line
File src/southbridge/intel/common/usb_debug.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145473): https://review.coreboot.org/c/coreboot/+/63387/comment/33ff8bdb_39d64309 PS1, Line 13: const struct device *dev; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145473): https://review.coreboot.org/c/coreboot/+/63387/comment/9c74254c_fac77f8e PS1, Line 13: const struct device *dev; please, no spaces at the start of a line