Change in coreboot[master]: mb/google/kukui: Add panel for Kodama

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Peichao Li (Code Review)

20 Aug 2019 20 Aug '19

4:14 a.m.

Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

mb/google/kukui: Add panel for Kodama

Declare the following panel for Kodama: - AUO B101UAN08.3

BUG=b:139699622 TEST=builds Kodama image and working properly

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/35001/1

diff --git a/src/mainboard/google/kukui/panel_kodama.c b/src/mainboard/google/kukui/panel_kodama.c index 8f7ef2b..f702be9 100644 --- a/src/mainboard/google/kukui/panel_kodama.c +++ b/src/mainboard/google/kukui/panel_kodama.c @@ -15,6 +15,72 @@

#include "panel.h"

+static struct panel_description AUO_B101UAN08_3 = { + .edid = { + .ascii_string = "B101UAN08.3", + .manufacturer_name = "AUO", + .panel_bits_per_color = 8, + .panel_bits_per_pixel = 24, + .mode = { + .name = "1200x1920@60Hz", + .pixel_clock = 159192, + .lvds_dual_channel = 0, + .refresh = 60, + .ha = 1200, .hbl = 144, .hso = 60, .hspw = 4, + .va = 1920, .vbl = 60, .vso = 34, .vspw = 2, + .phsync = '-', .pvsync = '-', + .x_mm = 135, .y_mm = 216, + }, + }, + .orientation = LB_FB_ORIENTATION_LEFT_UP, + .init = { + INIT_DELAY_CMD(24), + INIT_DCS_CMD(0xB0, 0x01), + INIT_DCS_CMD(0xC0, 0x48), + INIT_DCS_CMD(0xC1, 0x48), + INIT_DCS_CMD(0xC2, 0x47), + INIT_DCS_CMD(0xC3, 0x47), + INIT_DCS_CMD(0xC4, 0x46), + INIT_DCS_CMD(0xC5, 0x46), + INIT_DCS_CMD(0xC6, 0x45), + INIT_DCS_CMD(0xC7, 0x45), + INIT_DCS_CMD(0xC8, 0x64), + INIT_DCS_CMD(0xC9, 0x64), + INIT_DCS_CMD(0xCA, 0x4F), + INIT_DCS_CMD(0xCB, 0x4F), + INIT_DCS_CMD(0xCC, 0x40), + INIT_DCS_CMD(0xCD, 0x40), + INIT_DCS_CMD(0xCE, 0x66), + INIT_DCS_CMD(0xCF, 0x66), + INIT_DCS_CMD(0xD0, 0x4F), + INIT_DCS_CMD(0xD1, 0x4F), + INIT_DCS_CMD(0xD2, 0x41), + INIT_DCS_CMD(0xD3, 0x41), + INIT_DCS_CMD(0xD4, 0x48), + INIT_DCS_CMD(0xD5, 0x48), + INIT_DCS_CMD(0xD6, 0x47), + INIT_DCS_CMD(0xD7, 0x47), + INIT_DCS_CMD(0xD8, 0x46), + INIT_DCS_CMD(0xD9, 0x46), + INIT_DCS_CMD(0xDA, 0x45), + INIT_DCS_CMD(0xDB, 0x45), + INIT_DCS_CMD(0xDC, 0x64), + INIT_DCS_CMD(0xDD, 0x64), + INIT_DCS_CMD(0xDE, 0x4F), + INIT_DCS_CMD(0xDF, 0x4F), + INIT_DCS_CMD(0xE0, 0x40), + INIT_DCS_CMD(0xE1, 0x40), + INIT_DCS_CMD(0xE2, 0x66), + INIT_DCS_CMD(0xE3, 0x66), + INIT_DCS_CMD(0xE4, 0x4F), + INIT_DCS_CMD(0xE5, 0x4F), + INIT_DCS_CMD(0xE6, 0x41), + INIT_DCS_CMD(0xE7, 0x41), + INIT_DELAY_CMD(150), + INIT_END_CMD, + }, +}; + static struct panel_description BOE_TV101WUM_N53 = { .edid = { .ascii_string = "TV101WUM-N53", @@ -331,6 +397,7 @@ };

static struct panel_description *kodama_panels[] = { + [1] = &AUO_B101UAN08_3, [2] = &BOE_TV101WUM_N53, };

Attachments:

attachment.htm (text/html — 7.8 KB)

Show replies by date

Hung-Te Lin (Code Review)

20 Aug 20 Aug

7:13 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 1:

We've decided to migrate into CBFS form. Please rebase on top of https://review.coreboot.org/c/coreboot/+/34877 .

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Magf - magf@bitland.corp-partner.google.com Gerrit-Comment-Date: Tue, 20 Aug 2019 05:13:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

7:14 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35001/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_kodama.c:

https://review.coreboot.org/c/coreboot/+/35001/1/src/mainboard/google/kukui/... PS1, Line 400: [1] Please check with ayowu@ for panel ID assignment. I think he'll recommend you to use other value?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Magf - magf@bitland.corp-partner.google.com Gerrit-Comment-Date: Tue, 20 Aug 2019 05:14:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Peichao Li (Code Review)

7:28 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35001/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_kodama.c:

https://review.coreboot.org/c/coreboot/+/35001/1/src/mainboard/google/kukui/... PS1, Line 400: [1]

...

Please check with ayowu@ for panel ID assignment. […]

AUO panel ID is 1, you can check issue ticket: 139699622. Panel ID info like below: get_active_panel: Found ID 1: 'AUO B101UAN08.3' 1200x1920@60Hz

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Magf - magf@bitland.corp-partner.google.com Gerrit-Comment-Date: Tue, 20 Aug 2019 05:28:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

7:35 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 1:

ok ID 1 is signed off. please rebase this so it'll be in the new CBFS style.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 1 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Magf - magf@bitland.corp-partner.google.com Gerrit-Comment-Date: Tue, 20 Aug 2019 05:35:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Peichao Li (Code Review)

8:10 a.m.

Hello Zhuohao Lee, Hung-Te Lin, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35001

to look at the new patch set (#3).

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

mb/google/kukui: Add panel for Kodama

Declare the following panel for Kodama: - AUO B101UAN08.3

BUG=b:139699622 TEST=builds Kodama image and working properly

Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f --- M src/mainboard/google/kukui/panel_kodama.c M src/mainboard/google/kukui/panel_params/Makefile.inc A src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c 3 files changed, 84 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/35001/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 3 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Magf - magf@bitland.corp-partner.google.com Gerrit-MessageType: newpatchset

Hung-Te Lin (Code Review)

8:15 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 3:

(2 comments)

be aware that CBFS patch has been changed (and you just reverted it) - please rebase again with latest version before uploading new one.

https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... PS3, Line 5: panel-AUO_B101UAN08_3 sort alphabetically (i.e., move AUO before BOE)

https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c:

https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... PS3, Line 25: .name = "1200x1920@60Hz", do not declare name here.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 3 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Magf - magf@bitland.corp-partner.google.com Gerrit-Comment-Date: Tue, 20 Aug 2019 06:15:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

8:16 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c:

https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... PS3, Line 4: Huaqin Are you sure?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 3 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Magf - magf@bitland.corp-partner.google.com Gerrit-Comment-Date: Tue, 20 Aug 2019 06:16:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Peichao Li (Code Review)

8:24 a.m.

Hello Zhuohao Lee, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35001

to look at the new patch set (#4).

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

mb/google/kukui: Add panel for Kodama

Declare the following panel for Kodama: - AUO B101UAN08.3

BUG=b:139699622 TEST=builds Kodama image and working properly

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/35001/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 4 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Magf - magf@bitland.corp-partner.google.com Gerrit-MessageType: newpatchset

Peichao Li (Code Review)

8:43 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35001/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_kodama.c:

https://review.coreboot.org/c/coreboot/+/35001/1/src/mainboard/google/kukui/... PS1, Line 400: [1]

...

AUO panel ID is 1, you can check issue ticket: 139699622. Panel ID info like below: […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 4 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Magf - magf@bitland.corp-partner.google.com Gerrit-Comment-Date: Tue, 20 Aug 2019 06:43:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peichao Li peichao.wang@bitland.corp-partner.google.com Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Gerrit-MessageType: comment

Peichao Li (Code Review)

8:44 a.m.

Peichao Li has removed Magf - from this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Removed reviewer Magf -.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 4 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: deleteReviewer

Peichao Li (Code Review)

9:53 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 4:

Dear Hung-te,

Why compiler prompt: It's so weird. Please kindly help take a look. panel-AUO_B101UAN08_3.c:18:39: error: 'AUO_B101UAN08_3' defined but not used [-Werror=unused-variable]

Thanks and best regards

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 4 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 20 Aug 2019 07:53:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

9:55 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35001/4/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c:

https://review.coreboot.org/c/coreboot/+/35001/4/src/mainboard/google/kukui/... PS4, Line 18: static you cannot put static.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 4 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 20 Aug 2019 07:55:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Peichao Li (Code Review)

10:54 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 4:

...

Patch Set 4:

(1 comment)

Dear Hung-te,

I have build it successfully, Can I upload it without static? Thanks a lot!

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 4 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 20 Aug 2019 08:54:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Peichao Li (Code Review)

10:55 a.m.

Hello Zhuohao Lee, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35001

to look at the new patch set (#5).

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

mb/google/kukui: Add panel for Kodama

Declare the following panel for Kodama: - AUO B101UAN08.3

BUG=b:139699622 TEST=builds Kodama image and working properly

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/35001/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 5 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Peichao Li (Code Review)

10:57 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35001/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_kodama.c:

https://review.coreboot.org/c/coreboot/+/35001/1/src/mainboard/google/kukui/... PS1, Line 400: [1]

...

Done

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 5 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 20 Aug 2019 08:57:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peichao Li peichao.wang@bitland.corp-partner.google.com Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Gerrit-MessageType: comment

Peichao Li (Code Review)

12:07 p.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 5:

(4 comments)

https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... PS3, Line 5: panel-AUO_B101UAN08_3

...

sort alphabetically (i.e. […]

Done

https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c:

https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... PS3, Line 4: Huaqin

...

Are you sure?

Done

https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... PS3, Line 25: .name = "1200x1920@60Hz",

...

do not declare name here.

Done

https://review.coreboot.org/c/coreboot/+/35001/4/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c:

https://review.coreboot.org/c/coreboot/+/35001/4/src/mainboard/google/kukui/... PS4, Line 18: static

...

you cannot put static.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 5 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 20 Aug 2019 10:07:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

22 Aug 22 Aug

1:38 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35001/5/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35001/5/src/mainboard/google/kukui/... PS5, Line 2: panel-params-$(CONFIG_BOARD_GOOGLE_KODAMA) += panel-AUO_B101UAN08_3 sorry, we should still sort by $(CONFIG_*) first here, otherwise it'll be pretty hard to manage...

please put this in

panel-...KRANE += ... AUO panel-...KRANE += ... BOE panel-...KODAMA += ... AUO panel-...KODAMA += ... BOE

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 5 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 21 Aug 2019 23:38:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Peichao Li (Code Review)

2:34 a.m.

Hello Zhuohao Lee, Hung-Te Lin, build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35001

to look at the new patch set (#6).

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

mb/google/kukui: Add panel for Kodama

Declare the following panel for Kodama: - AUO B101UAN08.3

BUG=b:139699622 TEST=builds Kodama image and working properly

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/35001/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 6 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Peichao Li (Code Review)

2:35 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35001/5/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/35001/5/src/mainboard/google/kukui/... PS5, Line 2: panel-params-$(CONFIG_BOARD_GOOGLE_KODAMA) += panel-AUO_B101UAN08_3

...

sorry, we should still sort by $(CONFIG_*) first here, otherwise it'll be pretty hard to manage... […]

Done

https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c:

https://review.coreboot.org/c/coreboot/+/35001/3/src/mainboard/google/kukui/... PS3, Line 4: Huaqin

...

Done

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 6 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 22 Aug 2019 00:35:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Peichao Li peichao.wang@bitland.corp-partner.google.com Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

2:38 a.m.

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 6 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 22 Aug 2019 00:38:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Peichao Li (Code Review)

3:01 a.m.

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

Patch Set 6: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 6 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 22 Aug 2019 01:01:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

23 Aug 23 Aug

8:32 a.m.

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35001 )

Change subject: mb/google/kukui: Add panel for Kodama ......................................................................

mb/google/kukui: Add panel for Kodama

Declare the following panel for Kodama: - AUO B101UAN08.3

BUG=b:139699622 TEST=builds Kodama image and working properly

Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Reviewed-on: https://review.coreboot.org/c/coreboot/+/35001 Reviewed-by: Hung-Te Lin hungte@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/panel_kodama.c M src/mainboard/google/kukui/panel_params/Makefile.inc A src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c 3 files changed, 83 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Peichao Li: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/kukui/panel_kodama.c b/src/mainboard/google/kukui/panel_kodama.c index fe0152d..033e469 100644 --- a/src/mainboard/google/kukui/panel_kodama.c +++ b/src/mainboard/google/kukui/panel_kodama.c @@ -16,6 +16,7 @@ #include "panel.h"

static struct panel_description kodama_panels[] = { + [1] = { .name = "AUO_B101UAN08_3", }, [2] = { .name = "BOE_TV101WUM_N53", }, };

diff --git a/src/mainboard/google/kukui/panel_params/Makefile.inc b/src/mainboard/google/kukui/panel_params/Makefile.inc index c51992a..016dad0 100644 --- a/src/mainboard/google/kukui/panel_params/Makefile.inc +++ b/src/mainboard/google/kukui/panel_params/Makefile.inc @@ -1,6 +1,7 @@ panel-params-y := panel-params-$(CONFIG_BOARD_GOOGLE_KRANE) += panel-AUO_KD101N80_45NA panel-params-$(CONFIG_BOARD_GOOGLE_KRANE) += panel-BOE_TV101WUM_NL6 +panel-params-$(CONFIG_BOARD_GOOGLE_KODAMA) += panel-AUO_B101UAN08_3 panel-params-$(CONFIG_BOARD_GOOGLE_KODAMA) += panel-BOE_TV101WUM_N53 panel-params-$(CONFIG_BOARD_GOOGLE_KUKUI) += panel-CMN_P097PFG_SSD2858 panel-params-$(CONFIG_BOARD_GOOGLE_FLAPJACK) += panel-AUO_NT51021D8P diff --git a/src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c b/src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c new file mode 100644 index 0000000..a3da2a8 --- /dev/null +++ b/src/mainboard/google/kukui/panel_params/panel-AUO_B101UAN08_3.c @@ -0,0 +1,81 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2019 Bitland Tech Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include "../panel.h" + +struct panel_serializable_data AUO_B101UAN08_3 = { + .edid = { + .ascii_string = "B101UAN08.3", + .manufacturer_name = "AUO", + .panel_bits_per_color = 8, + .panel_bits_per_pixel = 24, + .mode = { + .pixel_clock = 159192, + .lvds_dual_channel = 0, + .refresh = 60, + .ha = 1200, .hbl = 144, .hso = 60, .hspw = 4, + .va = 1920, .vbl = 60, .vso = 34, .vspw = 2, + .phsync = '-', .pvsync = '-', + .x_mm = 135, .y_mm = 216, + }, + }, + .orientation = LB_FB_ORIENTATION_LEFT_UP, + .init = { + INIT_DELAY_CMD(24), + INIT_DCS_CMD(0xB0, 0x01), + INIT_DCS_CMD(0xC0, 0x48), + INIT_DCS_CMD(0xC1, 0x48), + INIT_DCS_CMD(0xC2, 0x47), + INIT_DCS_CMD(0xC3, 0x47), + INIT_DCS_CMD(0xC4, 0x46), + INIT_DCS_CMD(0xC5, 0x46), + INIT_DCS_CMD(0xC6, 0x45), + INIT_DCS_CMD(0xC7, 0x45), + INIT_DCS_CMD(0xC8, 0x64), + INIT_DCS_CMD(0xC9, 0x64), + INIT_DCS_CMD(0xCA, 0x4F), + INIT_DCS_CMD(0xCB, 0x4F), + INIT_DCS_CMD(0xCC, 0x40), + INIT_DCS_CMD(0xCD, 0x40), + INIT_DCS_CMD(0xCE, 0x66), + INIT_DCS_CMD(0xCF, 0x66), + INIT_DCS_CMD(0xD0, 0x4F), + INIT_DCS_CMD(0xD1, 0x4F), + INIT_DCS_CMD(0xD2, 0x41), + INIT_DCS_CMD(0xD3, 0x41), + INIT_DCS_CMD(0xD4, 0x48), + INIT_DCS_CMD(0xD5, 0x48), + INIT_DCS_CMD(0xD6, 0x47), + INIT_DCS_CMD(0xD7, 0x47), + INIT_DCS_CMD(0xD8, 0x46), + INIT_DCS_CMD(0xD9, 0x46), + INIT_DCS_CMD(0xDA, 0x45), + INIT_DCS_CMD(0xDB, 0x45), + INIT_DCS_CMD(0xDC, 0x64), + INIT_DCS_CMD(0xDD, 0x64), + INIT_DCS_CMD(0xDE, 0x4F), + INIT_DCS_CMD(0xDF, 0x4F), + INIT_DCS_CMD(0xE0, 0x40), + INIT_DCS_CMD(0xE1, 0x40), + INIT_DCS_CMD(0xE2, 0x66), + INIT_DCS_CMD(0xE3, 0x66), + INIT_DCS_CMD(0xE4, 0x4F), + INIT_DCS_CMD(0xE5, 0x4F), + INIT_DCS_CMD(0xE6, 0x41), + INIT_DCS_CMD(0xE7, 0x41), + INIT_DELAY_CMD(150), + INIT_END_CMD, + }, +};

-- To view, visit https://review.coreboot.org/c/coreboot/+/35001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f Gerrit-Change-Number: 35001 Gerrit-PatchSet: 7 Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

2079

days inactive

2082

days old

coreboot-gerrit@coreboot.org

22 comments

3 participants

tags (0)

participants (3)

Hung-Te Lin (Code Review)
Martin Roth (Code Review)
Peichao Li (Code Review)