Change in coreboot[master]: mb/google/dedede: Add smihandler stub

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Karthik Ramasubramanian (Code Review)

8 Jan 2020 8 Jan '20

11:03 a.m.

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38280 )

Change subject: mb/google/dedede: Add smihandler stub ......................................................................

mb/google/dedede: Add smihandler stub

Add stub implementation of smihandler.

BUG=b:144768001 TEST=Build test.

Change-Id: I7ab25888812bfb4578915e342b14355ccd15f5cc Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/Makefile.inc A src/mainboard/google/dedede/smihandler.c M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h 4 files changed, 47 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/38280/1

diff --git a/src/mainboard/google/dedede/Makefile.inc b/src/mainboard/google/dedede/Makefile.inc index 8f50113..f214544 100644 --- a/src/mainboard/google/dedede/Makefile.inc +++ b/src/mainboard/google/dedede/Makefile.inc @@ -2,6 +2,8 @@

ramstage-y += mainboard.c

+smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c + subdirs-y += variants/baseboard CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include

diff --git a/src/mainboard/google/dedede/smihandler.c b/src/mainboard/google/dedede/smihandler.c new file mode 100644 index 0000000..d4d9c65 --- /dev/null +++ b/src/mainboard/google/dedede/smihandler.c @@ -0,0 +1,33 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2020 The coreboot project Authors. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include <arch/acpi.h> +#include <baseboard/variants.h> +#include <cpu/x86/smm.h> +#include <intelblocks/smihandler.h> +#include <soc/pm.h> +#include <soc/gpio.h> +#include <variant/gpio.h> + +void mainboard_smi_gpi_handler(const struct gpi_status *sts) +{ +} + +void mainboard_smi_sleep(u8 slp_typ) +{ + const struct pad_config *pads; + size_t num; + + pads = variant_sleep_gpio_table(&num); + gpio_configure_pads(pads, num); +} + +int mainboard_smi_apmc(u8 apmc) +{ + return 0; +} diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index a141a58..c43e97f 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -31,3 +31,14 @@ *num = ARRAY_SIZE(early_gpio_table); return early_gpio_table; } + +/* GPIO settings before entering sleep. */ +static const struct pad_config sleep_gpio_table[] = { +}; + +const struct pad_config *__attribute__((weak)) + variant_sleep_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(sleep_gpio_table); + return sleep_gpio_table; +} diff --git a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h index ebcd594..309b9eb 100644 --- a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h @@ -17,5 +17,6 @@

const struct pad_config *variant_gpio_table(size_t *num); const struct pad_config *variant_early_gpio_table(size_t *num); +const struct pad_config *variant_sleep_gpio_table(size_t *num);

#endif /*__BASEBOARD_VARIANTS_H__ */

Attachments:

attachment.htm (text/html — 7.4 KB)

Show replies by date

Karthik Ramasubramanian (Code Review)

9 Jan 9 Jan

1:39 p.m.

Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38280

to look at the new patch set (#4).

Change subject: mb/google/dedede: Add smihandler stub ......................................................................

mb/google/dedede: Add smihandler stub

Add stub implementation of smihandler.

BUG=b:144768001 TEST=Build test.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/38280/4

Justin TerAvest (Code Review)

4:23 p.m.

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38280 )

Change subject: mb/google/dedede: Add smihandler stub ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/smihandler.c:

https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... PS4, Line 34: What about elog_gsmi_cb_mainboard_log_wake_source ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ab25888812bfb4578915e342b14355ccd15f5cc Gerrit-Change-Number: 38280 Gerrit-PatchSet: 4 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 09 Jan 2020 23:23:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

4:30 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38280 )

Change subject: mb/google/dedede: Add smihandler stub ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/smihandler.c:

https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... PS4, Line 34:

...

What about elog_gsmi_cb_mainboard_log_wake_source ?

I haven't enabled the support for ELOG yet. I am planning to add as a follow-up patch when we enable ELOG.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ab25888812bfb4578915e342b14355ccd15f5cc Gerrit-Change-Number: 38280 Gerrit-PatchSet: 4 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 09 Jan 2020 23:30:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Justin TerAvest teravest@chromium.org Gerrit-MessageType: comment

Justin TerAvest (Code Review)

4:32 p.m.

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38280 )

Change subject: mb/google/dedede: Add smihandler stub ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ab25888812bfb4578915e342b14355ccd15f5cc Gerrit-Change-Number: 38280 Gerrit-PatchSet: 4 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 09 Jan 2020 23:32:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

11 Jan 11 Jan

10:42 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38280 )

Change subject: mb/google/dedede: Add smihandler stub ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... PS4, Line 39: __attribute__((weak)) __weak

https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... PS4, Line 40: variant_sleep_gpio_table(size_t *num) nit: This might fit on the above line.

-- To view, visit https://review.coreboot.org/c/coreboot/+/38280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ab25888812bfb4578915e342b14355ccd15f5cc Gerrit-Change-Number: 38280 Gerrit-PatchSet: 4 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 11 Jan 2020 17:42:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

13 Jan 13 Jan

9:47 a.m.

Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38280

to look at the new patch set (#5).

Change subject: mb/google/dedede: Add smihandler stub ......................................................................

mb/google/dedede: Add smihandler stub

Add stub implementation of smihandler.

BUG=b:144768001 TEST=Build test.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/38280/5

build bot (Jenkins) (Code Review)

9:48 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38280 )

Change subject: mb/google/dedede: Add smihandler stub ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38280/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/38280/5/src/mainboard/google/dedede... PS5, Line 39: const struct pad_config *__weak variant_sleep_gpio_table(size_t *num) "foo *__weak bar" should be "foo *__weak bar"

-- To view, visit https://review.coreboot.org/c/coreboot/+/38280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ab25888812bfb4578915e342b14355ccd15f5cc Gerrit-Change-Number: 38280 Gerrit-PatchSet: 5 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 13 Jan 2020 16:48:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

9:52 a.m.

Hello Justin TerAvest, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38280

to look at the new patch set (#6).

Change subject: mb/google/dedede: Add smihandler stub ......................................................................

mb/google/dedede: Add smihandler stub

Add stub implementation of smihandler.

BUG=b:144768001 TEST=Build test.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/38280/6

Karthik Ramasubramanian (Code Review)

9:54 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38280 )

Change subject: mb/google/dedede: Add smihandler stub ......................................................................

Patch Set 6:

(4 comments)

https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/smihandler.c:

https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... PS4, Line 34:

...

I haven't enabled the support for ELOG yet. […]

Ack

https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... PS4, Line 39: __attribute__((weak))

...

__weak

Done

https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... PS4, Line 40: variant_sleep_gpio_table(size_t *num)

...

nit: This might fit on the above line.

Done

https://review.coreboot.org/c/coreboot/+/38280/5/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/38280/5/src/mainboard/google/dedede... PS5, Line 39: const struct pad_config *__weak variant_sleep_gpio_table(size_t *num)

...

"foo *__weak bar" should be "foo *__weak bar"

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ab25888812bfb4578915e342b14355ccd15f5cc Gerrit-Change-Number: 38280 Gerrit-PatchSet: 6 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 13 Jan 2020 16:54:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Comment-In-Reply-To: Justin TerAvest teravest@chromium.org Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

14 Jan 14 Jan

11:04 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38280 )

Change subject: mb/google/dedede: Add smihandler stub ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38280/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/smihandler.c:

https://review.coreboot.org/c/coreboot/+/38280/6/src/mainboard/google/dedede... PS6, Line 9: #include <arch/acpi.h> Are all these headers really required?

-- To view, visit https://review.coreboot.org/c/coreboot/+/38280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ab25888812bfb4578915e342b14355ccd15f5cc Gerrit-Change-Number: 38280 Gerrit-PatchSet: 6 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 14 Jan 2020 18:04:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

11:39 a.m.

Hello Balaji Manigandan, Aamir Bohra, Justin TerAvest, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38280

to look at the new patch set (#7).

Change subject: mb/google/dedede: Add smihandler stub ......................................................................

mb/google/dedede: Add smihandler stub

Add stub implementation of smihandler.

BUG=b:144768001 TEST=Build test.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/38280/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/38280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ab25888812bfb4578915e342b14355ccd15f5cc Gerrit-Change-Number: 38280 Gerrit-PatchSet: 7 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Karthik Ramasubramanian (Code Review)

11:41 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38280 )

Change subject: mb/google/dedede: Add smihandler stub ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38280/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/smihandler.c:

https://review.coreboot.org/c/coreboot/+/38280/6/src/mainboard/google/dedede... PS6, Line 9: #include <arch/acpi.h>

...

Are all these headers really required?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/38280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ab25888812bfb4578915e342b14355ccd15f5cc Gerrit-Change-Number: 38280 Gerrit-PatchSet: 7 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 14 Jan 2020 18:41:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

16 Jan 16 Jan

2:56 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38280 )

Change subject: mb/google/dedede: Add smihandler stub ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/38280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ab25888812bfb4578915e342b14355ccd15f5cc Gerrit-Change-Number: 38280 Gerrit-PatchSet: 7 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 16 Jan 2020 09:56:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

26 Jan 26 Jan

9:47 p.m.

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38280 )

Change subject: mb/google/dedede: Add smihandler stub ......................................................................

mb/google/dedede: Add smihandler stub

Add stub implementation of smihandler.

BUG=b:144768001 TEST=Build test.

Change-Id: I7ab25888812bfb4578915e342b14355ccd15f5cc Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38280 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/dedede/Makefile.inc A src/mainboard/google/dedede/smihandler.c M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h 4 files changed, 42 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

ramstage-y += mainboard.c

+smm-$(CONFIG_HAVE_SMI_HANDLER) += smihandler.c + subdirs-y += variants/baseboard CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/variants/baseboard/include

diff --git a/src/mainboard/google/dedede/smihandler.c b/src/mainboard/google/dedede/smihandler.c new file mode 100644 index 0000000..780d33f --- /dev/null +++ b/src/mainboard/google/dedede/smihandler.c @@ -0,0 +1,29 @@ +/* + * This file is part of the coreboot project. + * + * Copyright 2020 The coreboot project Authors. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include <baseboard/variants.h> +#include <cpu/x86/smm.h> +#include <intelblocks/smihandler.h> + +void mainboard_smi_gpi_handler(const struct gpi_status *sts) +{ +} + +void mainboard_smi_sleep(u8 slp_typ) +{ + const struct pad_config *pads; + size_t num; + + pads = variant_sleep_gpio_table(&num); + gpio_configure_pads(pads, num); +} + +int mainboard_smi_apmc(u8 apmc) +{ + return 0; +} diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index c94af6f..65ac66b 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -31,3 +31,13 @@ *num = ARRAY_SIZE(early_gpio_table); return early_gpio_table; } + +/* GPIO settings before entering sleep. */ +static const struct pad_config sleep_gpio_table[] = { +}; + +const struct pad_config *__weak variant_sleep_gpio_table(size_t *num) +{ + *num = ARRAY_SIZE(sleep_gpio_table); + return sleep_gpio_table; +} diff --git a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h index ebcd594..309b9eb 100644 --- a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h @@ -17,5 +17,6 @@

const struct pad_config *variant_gpio_table(size_t *num); const struct pad_config *variant_early_gpio_table(size_t *num); +const struct pad_config *variant_sleep_gpio_table(size_t *num);

#endif /*__BASEBOARD_VARIANTS_H__ */

-- To view, visit https://review.coreboot.org/c/coreboot/+/38280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ab25888812bfb4578915e342b14355ccd15f5cc Gerrit-Change-Number: 38280 Gerrit-PatchSet: 12 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Balaji Manigandan balaji.manigandan@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1932

days inactive

1951

days old

coreboot-gerrit@coreboot.org

14 comments

4 participants

tags (0)

participants (4)

build bot (Jenkins) (Code Review)
Furquan Shaikh (Code Review)
Justin TerAvest (Code Review)
Karthik Ramasubramanian (Code Review)