Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36596 )
Change subject: include: introduce update* for mmio operations ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36596/2/src/include/mmio.h File src/include/mmio.h:
https://review.coreboot.org/c/coreboot/+/36596/2/src/include/mmio.h@13 PS2, Line 13:
Ack
Done
https://review.coreboot.org/c/coreboot/+/36596/2/src/include/mmio.h@20 PS2, Line 20: const
um, what? […]
oooops :'D
https://review.coreboot.org/c/coreboot/+/36596/1/src/include/mmio.h File src/include/mmio.h:
https://review.coreboot.org/c/coreboot/+/36596/1/src/include/mmio.h@19 PS1, Line 19: static __always_inline void update8(const volatile void *addr, uint8_t mask, uint8_t or)
now I hate readX/writeX being bare w/o a namespace. […]
I'm a bit lost now as my parser doesn't seem to work today... :D so, did I get this right that we leave them as is and keep short names for update*(), too?