Hello Idwer Vollering,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37734
to review the following change.
Change subject: util/cbfstool: Further reduce warnings for lz4 code ......................................................................
util/cbfstool: Further reduce warnings for lz4 code
Some Clang version fails to inline all the FORCE_INLINE functions and complains.
Change-Id: I7b8349c9a3d53c47ac189f02b296600abac8a0cf Signed-off-by: Nico Huber nico.h@gmx.de --- M util/cbfstool/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/37734/1
diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc index 5c04848..066ef34 100644 --- a/util/cbfstool/Makefile.inc +++ b/util/cbfstool/Makefile.inc @@ -212,6 +212,7 @@ $(objutil)/cbfstool/mem_pool.o: TOOLCFLAGS += -Wno-sign-compare -Wno-cast-qual # Tolerate lz4 warnings $(objutil)/cbfstool/lz4.o: TOOLCFLAGS += -Wno-missing-prototypes +$(objutil)/cbfstool/lz4_wrapper.o: TOOLCFLAGS += -Wno-attributes
$(objutil)/cbfstool/fmd.o: $(objutil)/cbfstool/fmd_parser.h $(objutil)/cbfstool/fmd.o: $(objutil)/cbfstool/fmd_scanner.h
Hello Idwer Vollering, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37734
to look at the new patch set (#2).
Change subject: util/cbfstool: Further reduce warnings for lz4 code ......................................................................
util/cbfstool: Further reduce warnings for lz4 code
If the compiler fails to inline all the FORCE_INLINE functions, it will complains.
Change-Id: I7b8349c9a3d53c47ac189f02b296600abac8a0cf Signed-off-by: Nico Huber nico.h@gmx.de --- M util/cbfstool/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/37734/2
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37734 )
Change subject: util/cbfstool: Further reduce warnings for lz4 code ......................................................................
Patch Set 2: Code-Review+2
Tested on FreeBSD (13-CURRENT), by running 'gmake' in util/cbfstool/ Of course this is after 'menuconfig', so vb2_api.h will be present.
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37734 )
Change subject: util/cbfstool: Further reduce warnings for lz4 code ......................................................................
Patch Set 2:
Patch Set 2: Code-Review+2
Tested on FreeBSD (13-CURRENT), by running 'gmake' in util/cbfstool/ Of course this is after 'menuconfig', so vb2_api.h will be present.
With CC=gcc9
Patrick Georgi has uploaded a new patch set (#3) to the change originally created by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/37734 )
Change subject: util/cbfstool: Further reduce warnings for lz4 code ......................................................................
util/cbfstool: Further reduce warnings for lz4 code
If the compiler fails to inline all the FORCE_INLINE functions, it will complain.
Change-Id: I7b8349c9a3d53c47ac189f02b296600abac8a0cf Signed-off-by: Nico Huber nico.h@gmx.de --- M util/cbfstool/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/37734/3
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37734 )
Change subject: util/cbfstool: Further reduce warnings for lz4 code ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37734/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37734/2//COMMIT_MSG@10 PS2, Line 10: complains
complain
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37734 )
Change subject: util/cbfstool: Further reduce warnings for lz4 code ......................................................................
util/cbfstool: Further reduce warnings for lz4 code
If the compiler fails to inline all the FORCE_INLINE functions, it will complain.
Change-Id: I7b8349c9a3d53c47ac189f02b296600abac8a0cf Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/37734 Reviewed-by: Idwer Vollering vidwer@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/cbfstool/Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Idwer Vollering: Looks good to me, approved
diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.inc index 5c04848..066ef34 100644 --- a/util/cbfstool/Makefile.inc +++ b/util/cbfstool/Makefile.inc @@ -212,6 +212,7 @@ $(objutil)/cbfstool/mem_pool.o: TOOLCFLAGS += -Wno-sign-compare -Wno-cast-qual # Tolerate lz4 warnings $(objutil)/cbfstool/lz4.o: TOOLCFLAGS += -Wno-missing-prototypes +$(objutil)/cbfstool/lz4_wrapper.o: TOOLCFLAGS += -Wno-attributes
$(objutil)/cbfstool/fmd.o: $(objutil)/cbfstool/fmd_parser.h $(objutil)/cbfstool/fmd.o: $(objutil)/cbfstool/fmd_scanner.h
-
Idwer Vollering (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)