Attention is currently required from: Patrick Georgi. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59916 )
Change subject: libpayload: Provide includes for payloads ......................................................................
Patch Set 2:
(3 comments)
File payloads/libpayload/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/59916/comment/9addba7f_08175cea PS1, Line 74: early-headers-install: Is there any way to "cache" *.h files easily? I do not want to create dep-files by hand.
File payloads/libpayload/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/59916/comment/b9d32db3_1f83ba75 PS2, Line 75: printf " INSTALL $(obj)/libpayload/include\n" : install -m 755 -d "$(obj)/libpayload/include" : for file in `find include -name *.h -type f`; do \ : install -m 755 -d "$(obj)/libpayload/`dirname $$file`"; \ : install -m 644 "$$file" "$(obj)/libpayload/$$file"; \ : done : for file in `find $(coreboottop)/src/commonlib/bsd/include -name *.h -type f`; do \ : dest_file=$$(realpath --relative-to=$(coreboottop)/src/commonlib/bsd/ $$file); \ : install -m 755 -d "$(obj)/libpayload/`dirname $$dest_file`"; \ : install -m 644 "$$file" "$(obj)/libpayload/$$dest_file"; \ : done I am not sure, if we really need this. Payloads should be using the _install_ target anyway, so copying these files in this target might be sufficient.
Moreover, I do not think, that it is a good idea to merge the build and install trees.
https://review.coreboot.org/c/coreboot/+/59916/comment/88145e5d_9bcb8fa0 PS2, Line 133: dest_file=$$(realpath --relative-to=$(coreboottop)/src/commonlib/bsd/ $$file); \ Required due to the commonlib/bsd includes being higher in the FS.
-
Jakub Czapiga (Code Review)