Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37824 )
Change subject: superio/smsc/lpc47m10x: Expose pnp_enter/exit_conf_state ......................................................................
superio/smsc/lpc47m10x: Expose pnp_enter/exit_conf_state
Change-Id: I55915b63dbb097634a228193f62395e45a1f42fe Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/superio/smsc/lpc47m10x/early_serial.c M src/superio/smsc/lpc47m10x/lpc47m10x.h 2 files changed, 8 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/37824/1
diff --git a/src/superio/smsc/lpc47m10x/early_serial.c b/src/superio/smsc/lpc47m10x/early_serial.c index 96c0b5d..719faf4 100644 --- a/src/superio/smsc/lpc47m10x/early_serial.c +++ b/src/superio/smsc/lpc47m10x/early_serial.c @@ -20,13 +20,13 @@ #include <stdint.h> #include "lpc47m10x.h"
-static void pnp_enter_conf_state(pnp_devfn_t dev) +void pnp_enter_conf_state(pnp_devfn_t dev) { u16 port = dev >> 8; outb(0x55, port); }
-static void pnp_exit_conf_state(pnp_devfn_t dev) +void pnp_exit_conf_state(pnp_devfn_t dev) { u16 port = dev >> 8; outb(0xaa, port); diff --git a/src/superio/smsc/lpc47m10x/lpc47m10x.h b/src/superio/smsc/lpc47m10x/lpc47m10x.h index a83a6f2..0c393c5 100644 --- a/src/superio/smsc/lpc47m10x/lpc47m10x.h +++ b/src/superio/smsc/lpc47m10x/lpc47m10x.h @@ -19,6 +19,9 @@ #ifndef SUPERIO_SMSC_LPC47M10X_H #define SUPERIO_SMSC_LPC47M10X_H
+#include <device/pnp_type.h> +#include <stdint.h> + #define LPC47M10X2_FDC 0 /* Floppy */ #define LPC47M10X2_PP 3 /* Parallel Port */ #define LPC47M10X2_SP1 4 /* Com1 */ @@ -30,9 +33,9 @@
#define LPC47M10X2_MAX_CONFIG_REGISTER 0x5F
-#include <device/pnp_type.h> -#include <stdint.h> - void lpc47m10x_enable_serial(pnp_devfn_t dev, u16 iobase);
+void pnp_enter_conf_state(pnp_devfn_t dev); +void pnp_exit_conf_state(pnp_devfn_t dev); + #endif /* SUPERIO_SMSC_LPC47M10X_H */
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37824 )
Change subject: superio/smsc/lpc47m10x: Expose pnp_enter/exit_conf_state ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37824 )
Change subject: superio/smsc/lpc47m10x: Expose pnp_enter/exit_conf_state ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37824 )
Change subject: superio/smsc/lpc47m10x: Expose pnp_enter/exit_conf_state ......................................................................
superio/smsc/lpc47m10x: Expose pnp_enter/exit_conf_state
Change-Id: I55915b63dbb097634a228193f62395e45a1f42fe Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37824 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/superio/smsc/lpc47m10x/early_serial.c M src/superio/smsc/lpc47m10x/lpc47m10x.h 2 files changed, 8 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved
diff --git a/src/superio/smsc/lpc47m10x/early_serial.c b/src/superio/smsc/lpc47m10x/early_serial.c index 96c0b5d..719faf4 100644 --- a/src/superio/smsc/lpc47m10x/early_serial.c +++ b/src/superio/smsc/lpc47m10x/early_serial.c @@ -20,13 +20,13 @@ #include <stdint.h> #include "lpc47m10x.h"
-static void pnp_enter_conf_state(pnp_devfn_t dev) +void pnp_enter_conf_state(pnp_devfn_t dev) { u16 port = dev >> 8; outb(0x55, port); }
-static void pnp_exit_conf_state(pnp_devfn_t dev) +void pnp_exit_conf_state(pnp_devfn_t dev) { u16 port = dev >> 8; outb(0xaa, port); diff --git a/src/superio/smsc/lpc47m10x/lpc47m10x.h b/src/superio/smsc/lpc47m10x/lpc47m10x.h index a83a6f2..0c393c5 100644 --- a/src/superio/smsc/lpc47m10x/lpc47m10x.h +++ b/src/superio/smsc/lpc47m10x/lpc47m10x.h @@ -19,6 +19,9 @@ #ifndef SUPERIO_SMSC_LPC47M10X_H #define SUPERIO_SMSC_LPC47M10X_H
+#include <device/pnp_type.h> +#include <stdint.h> + #define LPC47M10X2_FDC 0 /* Floppy */ #define LPC47M10X2_PP 3 /* Parallel Port */ #define LPC47M10X2_SP1 4 /* Com1 */ @@ -30,9 +33,9 @@
#define LPC47M10X2_MAX_CONFIG_REGISTER 0x5F
-#include <device/pnp_type.h> -#include <stdint.h> - void lpc47m10x_enable_serial(pnp_devfn_t dev, u16 iobase);
+void pnp_enter_conf_state(pnp_devfn_t dev); +void pnp_exit_conf_state(pnp_devfn_t dev); + #endif /* SUPERIO_SMSC_LPC47M10X_H */
-
Felix Held (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)