Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62511 )
Change subject: mb/google/brya/var/nivviks: Configure WCAM DMIC data pin ......................................................................
mb/google/brya/var/nivviks: Configure WCAM DMIC data pin
GPP_S6 was accidentally configured twice instead of configuring GPP_S7. So configure GPP_S7 according to the schematics.
BUG=b:222218450 TEST=WCAM DMIC works on nivviks
Change-Id: I5de36aaa504a8856803c783564162c36416b50b7 Signed-off-by: Reka Norman rekanorman@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/62511 Reviewed-by: Kangheui Won khwon@chromium.org Reviewed-by: Sam McNally sammc@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brya/variants/nivviks/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Kangheui Won: Looks good to me, approved Sam McNally: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/nivviks/gpio.c b/src/mainboard/google/brya/variants/nivviks/gpio.c index e123567..f0700ab 100644 --- a/src/mainboard/google/brya/variants/nivviks/gpio.c +++ b/src/mainboard/google/brya/variants/nivviks/gpio.c @@ -26,7 +26,7 @@ /* S6 : DMIC_CLK_A_1 ==> DMIC_WCAM_CLK_R */ PAD_CFG_NF(GPP_S6, NONE, DEEP, NF2), /* S7 : DMIC_DATA_1 ==> DMIC_WCAM_DATA */ - PAD_CFG_NF(GPP_S6, NONE, DEEP, NF2), + PAD_CFG_NF(GPP_S7, NONE, DEEP, NF2), };
/* Early pad configuration in bootblock */