Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/11791 )
Change subject: mainboard/lenovo/t410: Add new port ......................................................................
Patch Set 19: Code-Review+1
(8 comments)
Few a header nits, but LGTM
https://review.coreboot.org/c/coreboot/+/11791/18/src/mainboard/lenovo/t410/... File src/mainboard/lenovo/t410/mainboard.c:
https://review.coreboot.org/c/coreboot/+/11791/18/src/mainboard/lenovo/t410/... PS18, Line 20: #include <device/pci_ops.h> remove?
https://review.coreboot.org/c/coreboot/+/11791/18/src/mainboard/lenovo/t410/... PS18, Line 22: #include <northbridge/intel/nehalem/nehalem.h> : #include <southbridge/intel/bd82x6x/pch.h> remove?
https://review.coreboot.org/c/coreboot/+/11791/19/src/mainboard/lenovo/t410/... File src/mainboard/lenovo/t410/romstage.c:
https://review.coreboot.org/c/coreboot/+/11791/19/src/mainboard/lenovo/t410/... PS19, Line 22: #include <string.h> remove?
https://review.coreboot.org/c/coreboot/+/11791/19/src/mainboard/lenovo/t410/... PS19, Line 23: #include <arch/io.h> remove
https://review.coreboot.org/c/coreboot/+/11791/19/src/mainboard/lenovo/t410/... PS19, Line 25: #include <device/pci_def.h> unused?
https://review.coreboot.org/c/coreboot/+/11791/19/src/mainboard/lenovo/t410/... PS19, Line 26: #include <device/pnp_def.h> unused
https://review.coreboot.org/c/coreboot/+/11791/19/src/mainboard/lenovo/t410/... PS19, Line 36: #include <arch/early_variables.h> remove
https://review.coreboot.org/c/coreboot/+/11791/18/src/mainboard/lenovo/t410/... File src/mainboard/lenovo/t410/thermal.h:
https://review.coreboot.org/c/coreboot/+/11791/18/src/mainboard/lenovo/t410/... PS18, Line 4: * Copyright (C) 2008-2009 coresystems GmbH : * Copyright (C) 2011 The Chromium OS Authors. All rights reserved. : * Copyright (C) 2014 Vladimir Serbinenko : * Copyright (C) 2016 Patrick Rudolph siro@das-labor.org : * Copyright (C) 2017 James Ye jye836@gmail.com : * makes little sense here?