Few a header nits, but LGTM
Patch set 19:Code-Review +1
8 comments:
File src/mainboard/lenovo/t410/mainboard.c:
Patch Set #18, Line 20: #include <device/pci_ops.h>
remove?
#include <northbridge/intel/nehalem/nehalem.h>
#include <southbridge/intel/bd82x6x/pch.h>
remove?
File src/mainboard/lenovo/t410/romstage.c:
Patch Set #19, Line 22: #include <string.h>
remove?
Patch Set #19, Line 23: #include <arch/io.h>
remove
Patch Set #19, Line 25: #include <device/pci_def.h>
unused?
Patch Set #19, Line 26: #include <device/pnp_def.h>
unused
Patch Set #19, Line 36: #include <arch/early_variables.h>
remove
File src/mainboard/lenovo/t410/thermal.h:
* Copyright (C) 2008-2009 coresystems GmbH
* Copyright (C) 2011 The Chromium OS Authors. All rights reserved.
* Copyright (C) 2014 Vladimir Serbinenko
* Copyright (C) 2016 Patrick Rudolph <siro@das-labor.org>
* Copyright (C) 2017 James Ye <jye836@gmail.com>
*
makes little sense here?
To view, visit change 11791. To unsubscribe, or for help writing mail filters, visit settings.