Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46713 )
Change subject: driver/usb/acpi: Add power resources for devices on USB ports ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46713/3/src/drivers/usb/acpi/usb_ac... File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/46713/3/src/drivers/usb/acpi/usb_ac... PS3, Line 17: cfg->has_power_resource || cfg->reset_gpio.pin_count == 0 This will have to be changed to: if (cfg->reset_gpio.pin_count != 0 && !cfg->has_power_resource) return true;
return false;
This is because there is another change coming where we are adding privacy gpio to _CRS. Anyways, I can provide feedback on that CL to ensure we coordinate the changes correctly.