Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37566 )
Change subject: Make debug flag available to all .c files ......................................................................
Make debug flag available to all .c files
This allows debugging information outside of the main file.
Change-Id: Ib8db75cf46cf157d4e2422a8b011c524c985e97d Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M em100.c M em100.h 2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/66/37566/1
diff --git a/em100.c b/em100.c index 25d9732..1ee22ec 100644 --- a/em100.c +++ b/em100.c @@ -27,6 +27,7 @@
TFILE *configs; char *database_version; +int debug = 0;
volatile int do_exit_flag = 0;
@@ -810,7 +811,7 @@ const char *holdpin = NULL; int do_start = 0, do_stop = 0; int verify = 0, trace = 0, terminal=0; - int debug = 0, compatibility = 0; + int compatibility = 0; int bus = 0, device = 0; int firmware_is_dpfw = 0; unsigned int serial_number = 0; diff --git a/em100.h b/em100.h index d48e52b..b003bd6 100644 --- a/em100.h +++ b/em100.h @@ -195,6 +195,7 @@ #define FILENAME_BUFFER_SIZE 1024 #define ARRAY_SIZE(a) (sizeof(a) / sizeof((a)[0])) char *get_em100_file(const char *name); +extern int debug;
/* Chips */ int parse_dcfg(chipdesc *chip, TFILE *dcfg);
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37566 )
Change subject: Make debug flag available to all .c files ......................................................................
Patch Set 1: Code-Review+2
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/37566 )
Change subject: Make debug flag available to all .c files ......................................................................
Make debug flag available to all .c files
This allows debugging information outside of the main file.
Change-Id: Ib8db75cf46cf157d4e2422a8b011c524c985e97d Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-on: https://review.coreboot.org/c/em100/+/37566 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M em100.c M em100.h 2 files changed, 3 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/em100.c b/em100.c index 25d9732..1ee22ec 100644 --- a/em100.c +++ b/em100.c @@ -27,6 +27,7 @@
TFILE *configs; char *database_version; +int debug = 0;
volatile int do_exit_flag = 0;
@@ -810,7 +811,7 @@ const char *holdpin = NULL; int do_start = 0, do_stop = 0; int verify = 0, trace = 0, terminal=0; - int debug = 0, compatibility = 0; + int compatibility = 0; int bus = 0, device = 0; int firmware_is_dpfw = 0; unsigned int serial_number = 0; diff --git a/em100.h b/em100.h index d48e52b..b003bd6 100644 --- a/em100.h +++ b/em100.h @@ -195,6 +195,7 @@ #define FILENAME_BUFFER_SIZE 1024 #define ARRAY_SIZE(a) (sizeof(a) / sizeof((a)[0])) char *get_em100_file(const char *name); +extern int debug;
/* Chips */ int parse_dcfg(chipdesc *chip, TFILE *dcfg);
-
Patrick Georgi (Code Review) -
Stefan Reinauer (Code Review)