Attention is currently required from: wouter.eckhardt@prodrive-technologies.com, Justin van Son, Patrick Rudolph, Christian Walter.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56086 )
Change subject: [TESTME] mb/prodrive/hermes: Update HDA codec subvendor ID
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/56086/comment/c1fb3865_66d70ba1
PS1, Line 10: AZALIA_SUBVENDOR(0, 0x1d330067),
I think the lower two bytes need to be swapped so it matches our ID, i.e. 0x1d336700.
Done, thanks.
File src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/56086/comment/7e3b3419_045d142a
PS2, Line 8: 0x10ec0888, /* Subsystem ID */
This might need to be changed too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56086
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72be8bde59d9eb0c1eff8c65dc734c6805732e09
Gerrit-Change-Number: 56086
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wouter.eckhardt@prodrive-technologies.com
Gerrit-Attention: wouter.eckhardt@prodrive-technologies.com
Gerrit-Attention: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Mon, 05 Jul 2021 13:18:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: wouter.eckhardt@prodrive-technologies.com
Gerrit-MessageType: comment