Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31104
Change subject: util/ifdtool: Add lock support for cnl and icl ......................................................................
util/ifdtool: Add lock support for cnl and icl
Cannonlake and Icelake have same read/write region permission settings with skylake and kabylake, so add it here as well.
BUG=b:123199222 TEST=Turn on CONFIG_LOCK_MANAGEMENT_ENGINE and build image, check the setting matches 0x0D for read and 0x04 for write.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I71d8b815c7dff7dcbcff2bf77c85ebf80b8df6d2 --- M util/ifdtool/ifdtool.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/31104/1
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 69cd2a9..1181e8c 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -965,6 +965,8 @@ /* TXE can only write Device Expansion */ fmba->flmstr2 |= 0x20 << wr_shift; break; + case PLATFORM_CNL: + case PLATFORM_ICL: case PLATFORM_SKLKBL: /* CPU/BIOS can read descriptor, BIOS and GbE. */ fmba->flmstr1 |= 0xb << rd_shift;
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31104 )
Change subject: util/ifdtool: Add lock support for cnl and icl ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31104/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31104/1//COMMIT_MSG@7 PS1, Line 7: cnl Maybe write CNL and ICL uppercase
Hello Angel Pons, Stefan Reinauer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31104
to look at the new patch set (#2).
Change subject: util/ifdtool: Add lock support for CNL and ICL ......................................................................
util/ifdtool: Add lock support for CNL and ICL
Cannonlake and Icelake have same read/write region permission settings with skylake and kabylake, so add it here as well.
BUG=b:123199222 TEST=Turn on CONFIG_LOCK_MANAGEMENT_ENGINE and build image, check the setting matches 0x0D for read and 0x04 for write.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I71d8b815c7dff7dcbcff2bf77c85ebf80b8df6d2 --- M util/ifdtool/ifdtool.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/31104/2
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31104 )
Change subject: util/ifdtool: Add lock support for CNL and ICL ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31104/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31104/1//COMMIT_MSG@7 PS1, Line 7: cnl
Maybe write CNL and ICL uppercase
Done
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31104 )
Change subject: util/ifdtool: Add lock support for CNL and ICL ......................................................................
Patch Set 3: Code-Review+2
This change is ready for review.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31104 )
Change subject: util/ifdtool: Add lock support for CNL and ICL ......................................................................
Patch Set 3: Code-Review+1
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31104 )
Change subject: util/ifdtool: Add lock support for CNL and ICL ......................................................................
util/ifdtool: Add lock support for CNL and ICL
Cannonlake and Icelake have same read/write region permission settings with skylake and kabylake, so add it here as well.
BUG=b:123199222 TEST=Turn on CONFIG_LOCK_MANAGEMENT_ENGINE and build image, check the setting matches 0x0D for read and 0x04 for write.
Signed-off-by: Lijian Zhao lijian.zhao@intel.com Change-Id: I71d8b815c7dff7dcbcff2bf77c85ebf80b8df6d2 Reviewed-on: https://review.coreboot.org/c/31104 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M util/ifdtool/ifdtool.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 69cd2a9..1181e8c 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -965,6 +965,8 @@ /* TXE can only write Device Expansion */ fmba->flmstr2 |= 0x20 << wr_shift; break; + case PLATFORM_CNL: + case PLATFORM_ICL: case PLATFORM_SKLKBL: /* CPU/BIOS can read descriptor, BIOS and GbE. */ fmba->flmstr1 |= 0xb << rd_shift;