Hello Varun Joshi,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/40001
to review the following change.
Change subject: mb/google/deltaur: Support to enable GbE ......................................................................
mb/google/deltaur: Support to enable GbE
Configure devicetree for enabling GbE.
Signed-off-by: Varun Joshi varun.joshi@intel.corp-partner.google.com Change-Id: I1c36b132546049e3e775585c41164072f4ece73e --- M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/40001/1
diff --git a/src/mainboard/google/deltaur/variants/deltan/overridetree.cb b/src/mainboard/google/deltaur/variants/deltan/overridetree.cb index 32204c5..5a0ab20 100644 --- a/src/mainboard/google/deltaur/variants/deltan/overridetree.cb +++ b/src/mainboard/google/deltaur/variants/deltan/overridetree.cb @@ -1,6 +1,11 @@ chip soc/intel/tigerlake
+ #PCIe Port 8 for LAN + register "PcieRpEnable[7]" = "1" + register "PcieClkSrcUsage[3]" = "PCIE_CLK_LAN" + register "PcieClkSrcClkReq[3]" = "3" device domain 0 on + device pci 1f.6 on end # GbE 0x15E1/0x15E2/0x15FC end
end
Hello Varun Joshi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40001
to look at the new patch set (#2).
Change subject: mb/google/deltaur: Support to enable GbE ......................................................................
mb/google/deltaur: Support to enable GbE
Configure devicetree for enabling GbE.
BUG=b:151102809
Signed-off-by: Varun Joshi varun.joshi@intel.corp-partner.google.com Change-Id: I1c36b132546049e3e775585c41164072f4ece73e --- M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/40001/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to enable GbE ......................................................................
Patch Set 2: Code-Review+1
@Tim already add this in baseboard. But if Deltaur doesn't have LAN. We should remove it from baseboard.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to enable GbE ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40001/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40001/2//COMMIT_MSG@7 PS2, Line 7: mb/google/deltaur: Support to enable GbE Enable GbE
https://review.coreboot.org/c/coreboot/+/40001/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40001/2/src/mainboard/google/deltau... PS2, Line 3: #PCIe Please add a space after #.
https://review.coreboot.org/c/coreboot/+/40001/2/src/mainboard/google/deltau... PS2, Line 8: device pci 1f.6 on end # GbE 0x15E1/0x15E2/0x15FC Less tabs for alignment could be used.
Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to enable GbE ......................................................................
Patch Set 2:
Patch Set 2: Code-Review+1
@Tim already add this in baseboard. But if Deltaur doesn't have LAN. We should remove it from baseboard.
I don't see the change in baseboard with my git tree, can you direct me to the patchset?
Hello Bora Guvendik, build bot (Jenkins), Tim Wawrzynczak, Furquan Shaikh, Varun Joshi, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40001
to look at the new patch set (#3).
Change subject: mb/google/deltaur: Support to Enable GbE ......................................................................
mb/google/deltaur: Support to Enable GbE
Configure devicetree for enabling GbE.
BUG=b:151102809
Signed-off-by: Varun Joshi varun.joshi@intel.corp-partner.google.com Change-Id: I1c36b132546049e3e775585c41164072f4ece73e --- M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/40001/3
Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to Enable GbE ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40001/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40001/2//COMMIT_MSG@7 PS2, Line 7: mb/google/deltaur: Support to enable GbE
Enable GbE
Done
https://review.coreboot.org/c/coreboot/+/40001/2/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40001/2/src/mainboard/google/deltau... PS2, Line 3: #PCIe
Please add a space after #.
Done
https://review.coreboot.org/c/coreboot/+/40001/2/src/mainboard/google/deltau... PS2, Line 8: device pci 1f.6 on end # GbE 0x15E1/0x15E2/0x15FC
Less tabs for alignment could be used.
Done
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to Enable GbE ......................................................................
Patch Set 3:
https://review.coreboot.org/c/coreboot/+/39678/11/src/mainboard/google/delta...
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to Enable GbE ......................................................................
Patch Set 3:
We miss this in Kconfig MAINBOARD_USES_IFD_GBE_REGION.
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to Enable GbE ......................................................................
Patch Set 3:
We also need to add GBE region in chromeos.fmd
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to Enable GbE ......................................................................
Patch Set 3:
Patch Set 2: Code-Review+1
@Tim already add this in baseboard. But if Deltaur doesn't have LAN. We should remove it from baseboard.
Deltaur will not have a LAN port, so it can be removed from the baseboard and moved to Deltan. Then we need to enable the Kconfig (IFD_GBE_REGION) and add the GbE section to chromeos.fmd. As long as we have the space, I'm not sure if we care that Deltaur may have the GbE blob in the IFWI even if it's not used.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to Enable GbE ......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 2: Code-Review+1
@Tim already add this in baseboard. But if Deltaur doesn't have LAN. We should remove it from baseboard.
Deltaur will not have a LAN port, so it can be removed from the baseboard and moved to Deltan. Then we need to enable the Kconfig (IFD_GBE_REGION) and add the GbE section to chromeos.fmd. As long as we have the space, I'm not sure if we care that Deltaur may have the GbE blob in the IFWI even if it's not used.
I think it's okay, because we level it in Arcada as well.
Hello Bora Guvendik, build bot (Jenkins), Tim Wawrzynczak, Furquan Shaikh, Varun Joshi, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40001
to look at the new patch set (#4).
Change subject: mb/google/deltaur: Support to Enable GbE on variant ......................................................................
mb/google/deltaur: Support to Enable GbE on variant
Configure devicetree for enabling GbE on variant.
BUG=b:151102809
Signed-off-by: Varun Joshi varun.joshi@intel.corp-partner.google.com Change-Id: I1c36b132546049e3e775585c41164072f4ece73e --- M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/40001/4
Hello Bora Guvendik, build bot (Jenkins), Tim Wawrzynczak, Furquan Shaikh, Varun Joshi, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40001
to look at the new patch set (#5).
Change subject: mb/google/deltaur: Support to Enable GbE on variant ......................................................................
mb/google/deltaur: Support to Enable GbE on variant
Configure devicetree for enabling GbE on variant.
BUG=b:151102809
Signed-off-by: Varun Joshi varun.joshi@intel.corp-partner.google.com Change-Id: I1c36b132546049e3e775585c41164072f4ece73e --- M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/40001/5
Hello Bora Guvendik, build bot (Jenkins), Tim Wawrzynczak, Furquan Shaikh, Varun Joshi, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40001
to look at the new patch set (#6).
Change subject: mb/google/deltaur: Support to Enable GbE on variant ......................................................................
mb/google/deltaur: Support to Enable GbE on variant
-Configure devicetree for enabling GbE on variant and remove from baseboard. -Configure Kconfig to enable GbE region.
BUG=b:151102809
Signed-off-by: Varun Joshi varun.joshi@intel.corp-partner.google.com Change-Id: I1c36b132546049e3e775585c41164072f4ece73e --- M src/mainboard/google/deltaur/Kconfig M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 3 files changed, 7 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/40001/6
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to Enable GbE on variant ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40001/6/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40001/6/src/mainboard/google/deltau... PS6, Line 7: nit: blank line before this
https://review.coreboot.org/c/coreboot/+/40001/6/src/mainboard/google/deltau... PS6, Line 8: 0x15E1/0x15E2/0x15FC Are these PCI IDs?
Hello Bora Guvendik, build bot (Jenkins), Tim Wawrzynczak, Furquan Shaikh, Varun Joshi, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40001
to look at the new patch set (#7).
Change subject: mb/google/deltaur: Support to Enable GbE on variant ......................................................................
mb/google/deltaur: Support to Enable GbE on variant
-Configure devicetree for enabling GbE on variant and remove from baseboard. -Configure Kconfig to enable GbE region.
BUG=b:151102809
Signed-off-by: Varun Joshi varun.joshi@intel.corp-partner.google.com Change-Id: I1c36b132546049e3e775585c41164072f4ece73e --- M src/mainboard/google/deltaur/Kconfig M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 3 files changed, 8 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/40001/7
Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to Enable GbE on variant ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40001/6/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40001/6/src/mainboard/google/deltau... PS6, Line 7:
nit: blank line before this
Done
https://review.coreboot.org/c/coreboot/+/40001/6/src/mainboard/google/deltau... PS6, Line 8: 0x15E1/0x15E2/0x15FC
Are these PCI IDs?
Yes Dev ID, Will be Keeping 15FC only.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to Enable GbE on variant ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40001/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40001/7//COMMIT_MSG@7 PS7, Line 7: mb/google/deltaur: Support to Enable GbE on variant Please make it a statement by adding a verb (in imperative mood).
https://review.coreboot.org/c/coreboot/+/40001/7//COMMIT_MSG@9 PS7, Line 9: -Configure devicetree for enabling GbE on variant Please remove the tab, and add a space after the “bullet”.
- Configure devicetree for …
https://review.coreboot.org/c/coreboot/+/40001/7//COMMIT_MSG@14 PS7, Line 14: Please remove the blank line.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to Enable GbE on variant ......................................................................
Patch Set 7:
Just one question, does this need to be coordinated with adding the GbE assets?
Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to Enable GbE on variant ......................................................................
Patch Set 7:
Patch Set 7:
Just one question, does this need to be coordinated with adding the GbE assets?
To enable GbE? - Yes, we would need the asset patch along with this.
Hello Bora Guvendik, build bot (Jenkins), Tim Wawrzynczak, Furquan Shaikh, Varun Joshi, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40001
to look at the new patch set (#8).
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
mb/google/deltaur: Add support to enable GbE on variant
- Configure devicetree for enabling GbE on variant and remove from baseboard. - Configure Kconfig to enable GbE region.
BUG=b:151102809 Signed-off-by: Varun Joshi varun.joshi@intel.corp-partner.google.com Change-Id: I1c36b132546049e3e775585c41164072f4ece73e --- M src/mainboard/google/deltaur/Kconfig M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 3 files changed, 8 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/40001/8
Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40001/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40001/7//COMMIT_MSG@7 PS7, Line 7: mb/google/deltaur: Support to Enable GbE on variant
Please make it a statement by adding a verb (in imperative mood).
Done
https://review.coreboot.org/c/coreboot/+/40001/7//COMMIT_MSG@9 PS7, Line 9: -Configure devicetree for enabling GbE on variant
Please remove the tab, and add a space after the “bullet”. […]
Done
https://review.coreboot.org/c/coreboot/+/40001/7//COMMIT_MSG@14 PS7, Line 14:
Please remove the blank line.
Done
Hello Bora Guvendik, build bot (Jenkins), Tim Wawrzynczak, Furquan Shaikh, Varun Joshi, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40001
to look at the new patch set (#9).
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
mb/google/deltaur: Add support to enable GbE on variant
- Configure devicetree for enabling GbE on variant and remove from baseboard. - Configure Kconfig to enable GbE region. - Configure fmd to incorporate GbE.
BUG=b:151102809 CQ-DEPEND=CL:*2843183 Signed-off-by: Varun Joshi varun.joshi@intel.corp-partner.google.com Change-Id: I1c36b132546049e3e775585c41164072f4ece73e --- M src/mainboard/google/deltaur/Kconfig M src/mainboard/google/deltaur/chromeos.fmd M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 4 files changed, 20 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/40001/9
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40001/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40001/9//COMMIT_MSG@14 PS9, Line 14: CQ-DEPEND=CL:*2843183 The syntax for this has changed: It has to go on a separate line from the BUG, and it should look like this:
Cq-Depend: chrome-internal:2843183 (for internal) OR Cq-Depend: chromium:1234567 (for public)
Hello Bora Guvendik, build bot (Jenkins), Tim Wawrzynczak, Furquan Shaikh, Varun Joshi, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40001
to look at the new patch set (#10).
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
mb/google/deltaur: Add support to enable GbE on variant
- Configure devicetree for enabling GbE on variant and remove from baseboard. - Configure Kconfig to enable GbE region. - Configure fmd to incorporate GbE.
BUG=b:151102809 Cq-Depend: chrome-internal:2843183 Signed-off-by: Varun Joshi varun.joshi@intel.corp-partner.google.com Change-Id: I1c36b132546049e3e775585c41164072f4ece73e --- M src/mainboard/google/deltaur/Kconfig M src/mainboard/google/deltaur/chromeos.fmd M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 4 files changed, 20 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/40001/10
Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40001/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40001/9//COMMIT_MSG@14 PS9, Line 14: CQ-DEPEND=CL:*2843183
The syntax for this has changed: […]
Done
https://review.coreboot.org/c/coreboot/+/40001/6/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40001/6/src/mainboard/google/deltau... PS6, Line 8: 0x15E1/0x15E2/0x15FC
Yes Dev ID, Will be Keeping 15FC only.
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
Patch Set 10: Code-Review+2
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
Patch Set 10: Code-Review+2
Patch Set 3:
We also need to add GBE region in chromeos.fmd
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40001/10/src/mainboard/google/delta... File src/mainboard/google/deltaur/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/40001/10/src/mainboard/google/delta... PS10, Line 5: SI_GBE@0x101000 0x2000 SI_GBE(PRESERVE)@0x101000 0x2000. We don't touch GBE when flash.
Hello Bora Guvendik, build bot (Jenkins), Tim Wawrzynczak, Furquan Shaikh, Varun Joshi, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40001
to look at the new patch set (#11).
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
mb/google/deltaur: Add support to enable GbE on variant
- Configure devicetree for enabling GbE on variant and remove from baseboard. - Configure Kconfig to enable GbE region. - Configure fmd to incorporate GbE.
BUG=b:151102809 Cq-Depend: chrome-internal:2843183 Signed-off-by: Varun Joshi varun.joshi@intel.corp-partner.google.com Change-Id: I1c36b132546049e3e775585c41164072f4ece73e --- M src/mainboard/google/deltaur/Kconfig M src/mainboard/google/deltaur/chromeos.fmd M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 4 files changed, 20 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/40001/11
Varun Joshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40001/10/src/mainboard/google/delta... File src/mainboard/google/deltaur/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/40001/10/src/mainboard/google/delta... PS10, Line 5: SI_GBE@0x101000 0x2000
SI_GBE(PRESERVE)@0x101000 0x2000. We don't touch GBE when flash.
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
Patch Set 11: Code-Review+2
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
Patch Set 11: Code-Review+2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
Patch Set 12: Code-Review+2
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
mb/google/deltaur: Add support to enable GbE on variant
- Configure devicetree for enabling GbE on variant and remove from baseboard. - Configure Kconfig to enable GbE region. - Configure fmd to incorporate GbE.
BUG=b:151102809 Cq-Depend: chrome-internal:2843183 Signed-off-by: Varun Joshi varun.joshi@intel.corp-partner.google.com Change-Id: I1c36b132546049e3e775585c41164072f4ece73e Reviewed-on: https://review.coreboot.org/c/coreboot/+/40001 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Bora Guvendik bora.guvendik@intel.com --- M src/mainboard/google/deltaur/Kconfig M src/mainboard/google/deltaur/chromeos.fmd M src/mainboard/google/deltaur/variants/baseboard/devicetree.cb M src/mainboard/google/deltaur/variants/deltan/overridetree.cb 4 files changed, 20 insertions(+), 17 deletions(-)
Approvals: build bot (Jenkins): Verified Bora Guvendik: Looks good to me, approved EricR Lai: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index 6b4af9b..cd4646c 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -15,6 +15,7 @@ select MAINBOARD_USES_IFD_EC_REGION select SOC_INTEL_TIGERLAKE select SYSTEM_TYPE_LAPTOP + select MAINBOARD_USES_IFD_GBE_REGION if BOARD_GOOGLE_DELTAN
if BOARD_GOOGLE_BASEBOARD_DELTAUR
diff --git a/src/mainboard/google/deltaur/chromeos.fmd b/src/mainboard/google/deltaur/chromeos.fmd index d0cf8e9..9b6fec3 100644 --- a/src/mainboard/google/deltaur/chromeos.fmd +++ b/src/mainboard/google/deltaur/chromeos.fmd @@ -1,26 +1,27 @@ FLASH@0xfe000000 0x2000000 { - SI_ALL@0x0 0x604000 { + SI_ALL@0x0 0x606000 { SI_DESC@0x0 0x1000 SI_EC@0x1000 0x100000 - SI_ME@0x101000 0x4ff000 - SI_PDR(PRESERVE)@0x600000 0x4000 + SI_GBE(PRESERVE)@0x101000 0x2000 + SI_ME@0x103000 0x4ff000 + SI_PDR(PRESERVE)@0x602000 0x4000 } - SI_BIOS@0x604000 0x19fc000 { - RW_DIAG@0x0 0x10cc000 { - RW_LEGACY(CBFS)@0x0 0x10bc000 - DIAG_NVRAM@0x10bc000 0x10000 + SI_BIOS@0x606000 0x19fa000 { + RW_DIAG@0x0 0x10ca000 { + RW_LEGACY(CBFS)@0x0 0x10ba000 + DIAG_NVRAM@0x10ba000 0x10000 } - RW_SECTION_A@0x10cc000 0x280000 { + RW_SECTION_A@0x10ca000 0x280000 { VBLOCK_A@0x0 0x10000 FW_MAIN_A(CBFS)@0x10000 0x26ffc0 RW_FWID_A@0x27ffc0 0x40 } - RW_SECTION_B@0x134c000 0x280000 { + RW_SECTION_B@0x134a000 0x280000 { VBLOCK_B@0x0 0x10000 FW_MAIN_B(CBFS)@0x10000 0x26ffc0 RW_FWID_B@0x27ffc0 0x40 } - RW_MISC@0x15cc000 0x30000 { + RW_MISC@0x15ca000 0x30000 { UNIFIED_MRC_CACHE@0x0 0x20000 { RECOVERY_MRC_CACHE@0x0 0x10000 RW_MRC_CACHE@0x10000 0x10000 @@ -33,7 +34,7 @@ RW_VPD(PRESERVE)@0x28000 0x2000 RW_NVRAM(PRESERVE)@0x2a000 0x6000 } - WP_RO@0x15fc000 0x400000 { + WP_RO@0x15fa000 0x400000 { RO_VPD(PRESERVE)@0x0 0x4000 RO_UNUSED@0x4000 0xc000 RO_SECTION@0x10000 0x3f0000 { diff --git a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb index a63d66c..a30c12d 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/deltaur/variants/baseboard/devicetree.cb @@ -59,11 +59,6 @@ register "PcieClkSrcUsage[4]" = "6" register "PcieClkSrcClkReq[4]" = "4"
- # PCIe port root 8 (LAN), clock 3 - register "PcieRpEnable[7]" = "1" - register "PcieClkSrcUsage[3]" = "PCIE_CLK_LAN" - register "PcieClkSrcClkReq[3]" = "3" - # PCIe root port 9 (NVMe), clock 2 register "PcieRpEnable[8]" = "1" register "PcieClkSrcUsage[2]" = "8" @@ -332,7 +327,7 @@ device pci 1f.3 on end # Intel HDA device pci 1f.4 on end # SMBus device pci 1f.5 on end # PCH SPI Flash Controller - device pci 1f.6 on end # GbE Controller + device pci 1f.6 off end # GbE Controller device pci 1f.7 off end # Intel Trace Hub end end diff --git a/src/mainboard/google/deltaur/variants/deltan/overridetree.cb b/src/mainboard/google/deltaur/variants/deltan/overridetree.cb index 32204c5..6a2719b 100644 --- a/src/mainboard/google/deltaur/variants/deltan/overridetree.cb +++ b/src/mainboard/google/deltaur/variants/deltan/overridetree.cb @@ -1,6 +1,12 @@ chip soc/intel/tigerlake
+ # PCIe Port 8 for LAN + register "PcieRpEnable[7]" = "1" + register "PcieClkSrcUsage[3]" = "PCIE_CLK_LAN" + register "PcieClkSrcClkReq[3]" = "3" + device domain 0 on + device pci 1f.6 on end # GbE 0x15FC end
end
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Add support to enable GbE on variant ......................................................................
Patch Set 15:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2302 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2301 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2300
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Bora Guvendik (Code Review)
-
EricR Lai (Code Review)
-
Martin Roth (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)
-
Varun Joshi (Code Review)