Change in coreboot[master]: mb/google/poppy: Power on PMIC before accessing its opregion
Sakari Ailus has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36722 )
Change subject: mb/google/poppy: Power on PMIC before accessing its opregion ......................................................................
mb/google/poppy: Power on PMIC before accessing its opregion
The PMIC opregion is used to change the direction of two GPIOs for I²C daisy chain operation. Do this after the PMIC is powered on, not before.
Reported-by: Laurent Pinchart laurent.pinchart@ideasonboard.com Signed-off-by: Sakari Ailus sakari.ailus@linux.intel.com Tested-by: Jacopo Mondi jacopo@jmondi.org Change-Id: I923987ef21a971df9e32ca03f2da4dccdac07843 --- M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/36722/1
diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl index d3fafe9..12c3c22 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl @@ -458,16 +458,16 @@ /* TODO: Read Voltage and Sleep values from Sensor Obj */ If (LEqual (AVBL, 1)) { If (LEqual (STA, 0)) { + /* Enable VSIO regulator + + daisy chain */ + DOVD(1) + If (LEqual (C0GP, 0)) { _SB.PCI0.I2C2.PMIC.CGP1() _SB.PCI0.I2C2.PMIC.CGP2() C0GP = 1 }
- /* Enable VSIO regulator + - daisy chain */ - DOVD(1) - VACT = 1 if (LNotEqual (ACVA, 109)) { /* Set ANA at 2.8152V */
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36722 )
Change subject: mb/google/poppy: Power on PMIC before accessing its opregion ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36722/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36722/1//COMMIT_MSG@11 PS1, Line 11: BUG=chromium:959232
Furquan Shaikh has uploaded a new patch set (#2) to the change originally created by Sakari Ailus. ( https://review.coreboot.org/c/coreboot/+/36722 )
Change subject: mb/google/poppy: Power on PMIC before accessing its opregion ......................................................................
mb/google/poppy: Power on PMIC before accessing its opregion
The PMIC opregion is used to change the direction of two GPIOs for I²C daisy chain operation. Do this after the PMIC is powered on, not before.
BUG=chromium:959232
Reported-by: Laurent Pinchart laurent.pinchart@ideasonboard.com Signed-off-by: Sakari Ailus sakari.ailus@linux.intel.com Tested-by: Jacopo Mondi jacopo@jmondi.org Change-Id: I923987ef21a971df9e32ca03f2da4dccdac07843 --- M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/36722/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36722 )
Change subject: mb/google/poppy: Power on PMIC before accessing its opregion ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36722/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36722/1//COMMIT_MSG@11 PS1, Line 11:
BUG=chromium:959232
Done
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36722 )
Change subject: mb/google/poppy: Power on PMIC before accessing its opregion ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36722 )
Change subject: mb/google/poppy: Power on PMIC before accessing its opregion ......................................................................
mb/google/poppy: Power on PMIC before accessing its opregion
The PMIC opregion is used to change the direction of two GPIOs for I²C daisy chain operation. Do this after the PMIC is powered on, not before.
BUG=chromium:959232
Reported-by: Laurent Pinchart laurent.pinchart@ideasonboard.com Signed-off-by: Sakari Ailus sakari.ailus@linux.intel.com Tested-by: Jacopo Mondi jacopo@jmondi.org Change-Id: I923987ef21a971df9e32ca03f2da4dccdac07843 Reviewed-on: https://review.coreboot.org/c/coreboot/+/36722 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl 1 file changed, 4 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl index d3fafe9..12c3c22 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl @@ -458,16 +458,16 @@ /* TODO: Read Voltage and Sleep values from Sensor Obj */ If (LEqual (AVBL, 1)) { If (LEqual (STA, 0)) { + /* Enable VSIO regulator + + daisy chain */ + DOVD(1) + If (LEqual (C0GP, 0)) { _SB.PCI0.I2C2.PMIC.CGP1() _SB.PCI0.I2C2.PMIC.CGP2() C0GP = 1 }
- /* Enable VSIO regulator + - daisy chain */ - DOVD(1) - VACT = 1 if (LNotEqual (ACVA, 109)) { /* Set ANA at 2.8152V */
-
Furquan Shaikh (Code Review) -
Patrick Georgi (Code Review)
-
Sakari Ailus (Code Review)