Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39427 )
Change subject: mb/ocp/tiogapass: use common GPIO config [WIP]
......................................................................
Patch Set 12: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39427/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39427/5//COMMIT_MSG@8
PS5, Line 8:
nit: may be shed some light where gpio settings come from? (e. […]
Done?
https://review.coreboot.org/c/coreboot/+/39427/12//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39427/12//COMMIT_MSG@10
PS12, Line 10: inte
inte*L*
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39427
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I818d040fa33f3e7b94b73c9bbbafca5df424616d
Gerrit-Change-Number: 39427
Gerrit-PatchSet: 12
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 23 Mar 2020 20:19:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Andrey Petrov
anpetrov@fb.com
Gerrit-MessageType: comment