Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/32729
Change subject: gma i2c: Increase timeout to >100ms ......................................................................
gma i2c: Increase timeout to >100ms
At least on the ThinkPad X200s with an oddly strapped (and unused) HDMI1, the GMBUS controller doesn't detect the NAK properly and only times out after around 100ms.
Change-Id: I48c2ef94e1449a98a35af6912c43156e4ed08206 Signed-off-by: Nico Huber nico.h@gmx.de --- M common/hw-gfx-gma-i2c.adb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/29/32729/1
diff --git a/common/hw-gfx-gma-i2c.adb b/common/hw-gfx-gma-i2c.adb index fe26f1c..bc81734 100644 --- a/common/hw-gfx-gma-i2c.adb +++ b/common/hw-gfx-gma-i2c.adb @@ -225,7 +225,7 @@ Registers.Wait_Set_Mask (Register => GMBUS_Regs (2), Mask => GMBUS2_HARDWARE_READY, - TOut_MS => 55); + TOut_MS => 110);
Registers.Read (GMBUS_Regs (2), GMBUS2); Success := (GMBUS2 and GMBUS2_HARDWARE_READY) /= 0 and
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/32729 )
Change subject: gma i2c: Increase timeout to >100ms ......................................................................
Patch Set 1: Verified+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/32729 )
Change subject: gma i2c: Increase timeout to >100ms ......................................................................
Patch Set 1: Code-Review+1
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/32729 )
Change subject: gma i2c: Increase timeout to >100ms ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/libgfxinit/+/32729 )
Change subject: gma i2c: Increase timeout to >100ms ......................................................................
gma i2c: Increase timeout to >100ms
At least on the ThinkPad X200s with an oddly strapped (and unused) HDMI1, the GMBUS controller doesn't detect the NAK properly and only times out after around 100ms.
Change-Id: I48c2ef94e1449a98a35af6912c43156e4ed08206 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/32729 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M common/hw-gfx-gma-i2c.adb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Nico Huber: Verified Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved
diff --git a/common/hw-gfx-gma-i2c.adb b/common/hw-gfx-gma-i2c.adb index fe26f1c..bc81734 100644 --- a/common/hw-gfx-gma-i2c.adb +++ b/common/hw-gfx-gma-i2c.adb @@ -225,7 +225,7 @@ Registers.Wait_Set_Mask (Register => GMBUS_Regs (2), Mask => GMBUS2_HARDWARE_READY, - TOut_MS => 55); + TOut_MS => 110);
Registers.Read (GMBUS_Regs (2), GMBUS2); Success := (GMBUS2 and GMBUS2_HARDWARE_READY) /= 0 and
-
Arthur Heymans (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)