Nico Huber merged this change.

View Change

Approvals: Nico Huber: Verified Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved
gma i2c: Increase timeout to >100ms

At least on the ThinkPad X200s with an oddly strapped (and unused)
HDMI1, the GMBUS controller doesn't detect the NAK properly and only
times out after around 100ms.

Change-Id: I48c2ef94e1449a98a35af6912c43156e4ed08206
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/32729
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
---
M common/hw-gfx-gma-i2c.adb
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/hw-gfx-gma-i2c.adb b/common/hw-gfx-gma-i2c.adb
index fe26f1c..bc81734 100644
--- a/common/hw-gfx-gma-i2c.adb
+++ b/common/hw-gfx-gma-i2c.adb
@@ -225,7 +225,7 @@
Registers.Wait_Set_Mask
(Register => GMBUS_Regs (2),
Mask => GMBUS2_HARDWARE_READY,
- TOut_MS => 55);
+ TOut_MS => 110);

Registers.Read (GMBUS_Regs (2), GMBUS2);
Success := (GMBUS2 and GMBUS2_HARDWARE_READY) /= 0 and

To view, visit change 32729. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I48c2ef94e1449a98a35af6912c43156e4ed08206
Gerrit-Change-Number: 32729
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged