Lean Sheng Tan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48541 )
Change subject: soc/intel/elkhartlake: Update USB_PORT_MID pin settings ......................................................................
soc/intel/elkhartlake: Update USB_PORT_MID pin settings
Update Pre-emphasis, Transmitter Emphasis & Preemphasis Bias values for USB_PORT_MID.
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: I43eeb0fc410197a559df97b340135fac65c00aa5 --- M src/soc/intel/elkhartlake/include/soc/usb.h 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/48541/1
diff --git a/src/soc/intel/elkhartlake/include/soc/usb.h b/src/soc/intel/elkhartlake/include/soc/usb.h index 247b0ba..3cef823 100644 --- a/src/soc/intel/elkhartlake/include/soc/usb.h +++ b/src/soc/intel/elkhartlake/include/soc/usb.h @@ -79,9 +79,9 @@ .enable = 1, \ .ocpin = (pin), \ .tx_bias = USB2_BIAS_0MV, \ - .tx_emp_enable = USB2_PRE_EMP_ON, \ - .pre_emp_bias = USB2_BIAS_56P3MV, \ - .pre_emp_bit = USB2_HALF_BIT_PRE_EMP, \ + .tx_emp_enable = USB2_DE_EMP_ON_PRE_EMP_ON, \ + .pre_emp_bias = USB2_BIAS_45MV, \ + .pre_emp_bit = USB2_FULL_BIT_PRE_EMP, \ }
/* Length = 3"-5.99" */
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48541 )
Change subject: soc/intel/elkhartlake: Update USB_PORT_MID pin settings ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Frans Hendriks, Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Werner Zeh, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48541
to look at the new patch set (#2).
Change subject: soc/intel/elkhartlake: Update USB_PORT_MID pin settings ......................................................................
soc/intel/elkhartlake: Update USB_PORT_MID pin settings
Update Pre-emphasis, Transmitter Emphasis & Preemphasis Bias values for USB_PORT_MID.
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: I43eeb0fc410197a559df97b340135fac65c00aa5 --- M src/soc/intel/elkhartlake/include/soc/usb.h 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/48541/2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48541 )
Change subject: soc/intel/elkhartlake: Update USB_PORT_MID pin settings ......................................................................
Patch Set 2: Code-Review+2
Werner Zeh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48541 )
Change subject: soc/intel/elkhartlake: Update USB_PORT_MID pin settings ......................................................................
soc/intel/elkhartlake: Update USB_PORT_MID pin settings
Update Pre-emphasis, Transmitter Emphasis & Preemphasis Bias values for USB_PORT_MID.
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: I43eeb0fc410197a559df97b340135fac65c00aa5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48541 Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Werner Zeh werner.zeh@siemens.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/elkhartlake/include/soc/usb.h 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved Frans Hendriks: Looks good to me, approved
diff --git a/src/soc/intel/elkhartlake/include/soc/usb.h b/src/soc/intel/elkhartlake/include/soc/usb.h index 247b0ba..3cef823 100644 --- a/src/soc/intel/elkhartlake/include/soc/usb.h +++ b/src/soc/intel/elkhartlake/include/soc/usb.h @@ -79,9 +79,9 @@ .enable = 1, \ .ocpin = (pin), \ .tx_bias = USB2_BIAS_0MV, \ - .tx_emp_enable = USB2_PRE_EMP_ON, \ - .pre_emp_bias = USB2_BIAS_56P3MV, \ - .pre_emp_bit = USB2_HALF_BIT_PRE_EMP, \ + .tx_emp_enable = USB2_DE_EMP_ON_PRE_EMP_ON, \ + .pre_emp_bias = USB2_BIAS_45MV, \ + .pre_emp_bit = USB2_FULL_BIT_PRE_EMP, \ }
/* Length = 3"-5.99" */
-
Frans Hendriks (Code Review) -
Lean Sheng Tan (Code Review)
-
Werner Zeh (Code Review)