Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48713 )
Change subject: soc/intel/tigerlake: Use FSP sources from FSP repository ......................................................................
Patch Set 2:
(1 comment)
+Nate for the missing CHANNEL_PRESENT definition in the released TGL FSP headers.
https://review.coreboot.org/c/coreboot/+/48713/2/src/soc/intel/tigerlake/rom... File src/soc/intel/tigerlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/48713/2/src/soc/intel/tigerlake/rom... PS2, Line 77: DIMM_PRESENT Even though the value of DIMM_PRESENT and CHANNEL_PRESENT happens to be same, it is not correct to use DIMM_PRESENT here. I think it was a miss that CHANNEL_PRESENT wasn't defined in MemoryInfoHob.h by the TGL FSP release. Can you please reach out to Nathaniel on the list to point this out? I am adding him here as well.
-
Furquan Shaikh (Code Review)