Change in coreboot[master]: drivers/intel/usb4: Update driver to support Retimer firmware upgrade - coreboot-gerrit

13 May 2021


      Attention is currently required from: John Zhao, Duncan Laurie.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52712 )
Change subject: drivers/intel/usb4: Update driver to support Retimer firmware upgrade
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/intel/usb4/retimer/chip.h:
https://review.coreboot.org/c/coreboot/+/52712/comment/0128f292_5967ea6e 
PS2, Line 14: uint8_t dfp_num;
This could be dropped and the code could instead loop through DFP_NUM_MAX and ignore entries that have an empty power_gpio for example
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52712
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81bef80729f6df57119f5523358620cb015e5406
Gerrit-Change-Number: 52712
Gerrit-PatchSet: 3
Gerrit-Owner: John Zhao john.zhao@intel.com
Gerrit-Reviewer: Duncan Laurie
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: John Zhao john.zhao@intel.com
Gerrit-Attention: Duncan Laurie
Gerrit-Comment-Date: Thu, 13 May 2021 03:20:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment