Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50486 )
Change subject: soc/amd/*/smihandler: use size_t and unsigned int ......................................................................
soc/amd/*/smihandler: use size_t and unsigned int
signed int should only be used when we need negative values and in those cases the value shouldn't became negative.
Change-Id: Iefac021260ff363c76bf5cd3fe3619ea1dbabdba Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/50486 Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/smihandler.c M src/soc/amd/stoneyridge/smihandler.c 2 files changed, 6 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/picasso/smihandler.c b/src/soc/amd/picasso/smihandler.c index 735fd77..d478aad 100644 --- a/src/soc/amd/picasso/smihandler.c +++ b/src/soc/amd/picasso/smihandler.c @@ -18,6 +18,7 @@ #include <amdblocks/smm.h> #include <elog.h> #include <soc/smu.h> +#include <types.h>
/* bits in smm_io_trap */ #define SMM_IO_TRAP_PORT_OFFSET 16 @@ -33,7 +34,7 @@
static void *find_save_state(int cmd) { - int core; + unsigned int core; amd64_smm_state_save_area_t *state; u32 smm_io_trap; u8 reg_al; @@ -225,7 +226,7 @@
void *get_smi_source_handler(int source) { - int i; + size_t i;
for (i = 0 ; i < ARRAY_SIZE(smi_sources) ; i++) if (smi_sources[i].type == source) diff --git a/src/soc/amd/stoneyridge/smihandler.c b/src/soc/amd/stoneyridge/smihandler.c index 3a65f55..23951b2 100644 --- a/src/soc/amd/stoneyridge/smihandler.c +++ b/src/soc/amd/stoneyridge/smihandler.c @@ -16,6 +16,7 @@ #include <amdblocks/smi.h> #include <amdblocks/smm.h> #include <elog.h> +#include <types.h>
/* bits in smm_io_trap */ #define SMM_IO_TRAP_PORT_OFFSET 16 @@ -31,7 +32,7 @@
static void *find_save_state(int cmd) { - int core; + unsigned int core; amd64_smm_state_save_area_t *state; u32 smm_io_trap; u8 reg_al; @@ -220,7 +221,7 @@
void *get_smi_source_handler(int source) { - int i; + size_t i;
for (i = 0 ; i < ARRAY_SIZE(smi_sources) ; i++) if (smi_sources[i].type == source)