Attention is currently required from: Felix Held, Jason Glenesk, Martin Roth, Matt DeVillier, Maximilian Brune, Patrick Rudolph, Raul Rangel.
Fred Reitberger has posted comments on this change by Fred Reitberger. ( https://review.coreboot.org/c/coreboot/+/68122?usp=email )
Change subject: soc/amd/common: Support sbin ucode files
......................................................................
Patch Set 9:
(2 comments)
File src/soc/amd/common/block/cpu/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/68122/comment/f95984f0_9c5860b2?usp... :
PS9, Line 15: # check for duplicate microcode files. Same sbin and bin ucode is allowed here though, because mendocino has a duplicate.
I just checked this out and it looks like both the Mendocino .bin and .sbin in amd_blobs have the same data.
https://review.coreboot.org/c/coreboot/+/68122/comment/9805ecef_58d5a29a?usp... :
PS9, Line 32: # if there is both a sbin and bin microcode only include the bin one to keep the old behaviour
When I last worked on this, the releases would be in '.sbin' format and we had to manually make the '.bin' variations. That was the reason for this patch in the first place.
If a new release updates the ucode and only provides a .sbin file, will this select the wrong file?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68122?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I29768ea19543bdc76662e687f59bf31b76f555ae
Gerrit-Change-Number: 68122
Gerrit-PatchSet: 9
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 03 Feb 2025 23:04:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No