Iru Cai has posted comments on this change. ( https://review.coreboot.org/20501 )
Change subject: mainboard/hp: Add HP Elitebook 8460p ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.cb File src/mainboard/hp/8460p/devicetree.cb:
https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/devicetree.cb... PS6, Line 17: chip northbridge/intel/sandybridge
remove all FIXMEs
I don't know if these gfx.did values are correct, although the display just works.
https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/romstage.c File src/mainboard/hp/8460p/romstage.c:
https://review.coreboot.org/#/c/20501/6/src/mainboard/hp/8460p/romstage.c@34 PS6, Line 34: {
On Ivybridge I've done:
Done
-
Iru Cai (Code Review)