Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81684?usp=email )
Change subject: soc/mediatek/common/include/soc: Include header file for check_member ......................................................................
soc/mediatek/common/include/soc: Include header file for check_member
To fix the build error below when include i2c_common.h, we should include the necessary header for check_member.
""" src/soc/mediatek/common/include/soc/i2c_common.h:24:42: error: expected ')' before numeric constant 24 | check_member(mt_i2c_dma_regs, dma_tx_len, 0x24); | ^~~~~ | ) """
TEST=abuild -t google/geralt -b ciri -a
Signed-off-by: Ruihai Zhou zhouruihai@huaqin.corp-partner.google.com Change-Id: I266571686e452e2b7514afee42ff0a48f8891831 Reviewed-on: https://review.coreboot.org/c/coreboot/+/81684 Reviewed-by: Elyes Haouas ehaouas@noos.fr Reviewed-by: Yidi Lin yidilin@google.com Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: cong yang yangcong5@huaqin.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/mediatek/common/include/soc/i2c_common.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: Yidi Lin: Looks good to me, approved Elyes Haouas: Looks good to me, approved cong yang: Looks good to me, but someone else must approve Eric Lai: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/soc/mediatek/common/include/soc/i2c_common.h b/src/soc/mediatek/common/include/soc/i2c_common.h index 4f4449c..63eef92 100644 --- a/src/soc/mediatek/common/include/soc/i2c_common.h +++ b/src/soc/mediatek/common/include/soc/i2c_common.h @@ -3,6 +3,7 @@ #ifndef MTK_COMMON_I2C_H #define MTK_COMMON_I2C_H
+#include <commonlib/bsd/helpers.h> #include <device/i2c.h>
/* I2C DMA Registers */