Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/58706 )
Change subject: lib/cbfs: Add CBFS_CACHE_ALIGN Kconfig option ......................................................................
lib/cbfs: Add CBFS_CACHE_ALIGN Kconfig option
This option will allow platforms to set the alignment of the cbfs_cache buffers.
BUG=b:179699789 TEST=gdb -ex 'p cbfs_cache' /tmp/coreboot/guybrush/cbfs/fallback/ramstage.debug $1 = {buf = 0x0, size = 0, alignment = 8, last_alloc = 0x0, second_to_last_alloc = 0x0, free_offset = 0}
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I74598d4bcbca9a01cc8c65012d7e4ae341d052b1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/58706 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Julius Werner jwerner@chromium.org --- M src/lib/Kconfig M src/lib/cbfs.c 2 files changed, 8 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/lib/Kconfig b/src/lib/Kconfig index 0f651b3..41a23b2 100644 --- a/src/lib/Kconfig +++ b/src/lib/Kconfig @@ -99,6 +99,12 @@ lookup must re-read the same CBFS directory entries from flash to find the respective file.
+config CBFS_CACHE_ALIGN + int + default 8 + help + Sets the alignment of the buffers returned by the cbfs_cache. + config PAYLOAD_PRELOAD bool depends on COOP_MULTITASKING diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c index 7633fdf..1c79b65 100644 --- a/src/lib/cbfs.c +++ b/src/lib/cbfs.c @@ -20,7 +20,7 @@
#if ENV_STAGE_HAS_DATA_SECTION struct mem_pool cbfs_cache = - MEM_POOL_INIT(_cbfs_cache, REGION_SIZE(cbfs_cache), sizeof(uint64_t)); + MEM_POOL_INIT(_cbfs_cache, REGION_SIZE(cbfs_cache), CONFIG_CBFS_CACHE_ALIGN); #else struct mem_pool cbfs_cache = MEM_POOL_INIT(NULL, 0, 0); #endif @@ -29,7 +29,7 @@ { if (_preram_cbfs_cache != _postram_cbfs_cache) mem_pool_init(&cbfs_cache, _postram_cbfs_cache, REGION_SIZE(postram_cbfs_cache), - sizeof(uint64_t)); + CONFIG_CBFS_CACHE_ALIGN); } ROMSTAGE_CBMEM_INIT_HOOK(switch_to_postram_cache);
6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.