Attention is currently required from: wouter.eckhardt@prodrive-technologies.com, Guido Beyer @ Prodrive Technologies, Justin van Son, Patrick Rudolph, Christian Walter, Angel Pons, Stef van Os.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54058 )
Change subject: mb/prodrive/hermes: Disable ACPI S3 and S4 with SPS
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
What about doing that in a more generic way by adding !HAVE_SPS / HAVE_SPS as dependency to HAVE_ACP […]
x11 boards could use that too, then
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54058
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d0fa8530e198e86415f92da6719d2fb0d2401ec
Gerrit-Change-Number: 54058
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Guido Beyer @ Prodrive Technologies
guido.beyer@prodrive-technologies.com
Gerrit-Reviewer: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Stef van Os
stef.van.os@prodrive-technologies.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wouter.eckhardt@prodrive-technologies.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: wouter.eckhardt@prodrive-technologies.com
Gerrit-Attention: Guido Beyer @ Prodrive Technologies
guido.beyer@prodrive-technologies.com
Gerrit-Attention: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Stef van Os
stef.van.os@prodrive-technologies.com
Gerrit-Comment-Date: Tue, 11 May 2021 13:11:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment