Change in coreboot[master]: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius

[Kevin Chiu (Code Review)]

Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48653 )

Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius
......................................................................

mb/google/zork: update USB 2.0 controller Lane Parameter for morphius

from AMD USB phy specialist recommended that TXVREFTUNE0 shouldn't over 0xD (the maximum)
in order to have enough room to accomdate a safe disconnect threshhold in COMPDISTUNE0.
TXVREFTUNE0: 0xf -> 0xd

BUG=b:172687208
BRANCH=zork
TEST=emerge-zork coreboot

Signed-off-by: Kevin Chiu 
Change-Id: Ia104454d95e5e8d6a212c97fb09d61125945eeea
---
M src/mainboard/google/zork/variants/morphius/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/48653/1

diff --git a/src/mainboard/google/zork/variants/morphius/overridetree.cb b/src/mainboard/google/zork/variants/morphius/overridetree.cb
index dbdf2e9..bee59e6 100644
--- a/src/mainboard/google/zork/variants/morphius/overridetree.cb
+++ b/src/mainboard/google/zork/variants/morphius/overridetree.cb
@@ -43,7 +43,7 @@
    	.tx_pre_emp_amp_tune = 0x03,
    	.tx_pre_emp_pulse_tune = 0x0,
    	.tx_rise_tune = 0x1,
-		.tx_vref_tune = 0xf,
+		.tx_vref_tune = 0xd,
    	.tx_hsxv_tune = 0x3,
    	.tx_res_tune = 0x01,
    }"

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48653 )

Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius
......................................................................

Patch Set 1: Code-Review+2

[Keith Tzeng (Code Review)]

Keith Tzeng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48653 )

Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius
......................................................................

Patch Set 1:

Could we merge this? thanks.

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48653 )

Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius
......................................................................

mb/google/zork: update USB 2.0 controller Lane Parameter for morphius

from AMD USB phy specialist recommended that TXVREFTUNE0 shouldn't over 0xD (the maximum)
in order to have enough room to accomdate a safe disconnect threshhold in COMPDISTUNE0.
TXVREFTUNE0: 0xf -> 0xd

BUG=b:172687208
BRANCH=zork
TEST=emerge-zork coreboot

Signed-off-by: Kevin Chiu 
Change-Id: Ia104454d95e5e8d6a212c97fb09d61125945eeea
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48653
Tested-by: build bot (Jenkins) 
Reviewed-by: Felix Held 
---
M src/mainboard/google/zork/variants/morphius/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved

diff --git a/src/mainboard/google/zork/variants/morphius/overridetree.cb b/src/mainboard/google/zork/variants/morphius/overridetree.cb
index dbdf2e9..bee59e6 100644
--- a/src/mainboard/google/zork/variants/morphius/overridetree.cb
+++ b/src/mainboard/google/zork/variants/morphius/overridetree.cb
@@ -43,7 +43,7 @@
    	.tx_pre_emp_amp_tune = 0x03,
    	.tx_pre_emp_pulse_tune = 0x0,
    	.tx_rise_tune = 0x1,
-		.tx_vref_tune = 0xf,
+		.tx_vref_tune = 0xd,
    	.tx_hsxv_tune = 0x3,
    	.tx_res_tune = 0x01,
    }"

[Keith Tzeng (Code Review)]

Keith Tzeng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48653 )

Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius
......................................................................

Patch Set 2:

please help pull into chrome tree fw branch. thanks.

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48653 )

Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius
......................................................................

Patch Set 2:
> Patch Set 2:
>
> please help pull into chrome tree fw branch. thanks.

https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...