Change in coreboot[master]: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor

[Varshit B Pandya (Code Review)]

Varshit B Pandya has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

mb/google/dedede: Add VCM and NVM entry for OV8856 sensor

Add support for DW9768 and AT24

Signed-off-by: Pandya, Varshit B 
Change-Id: I19e4a4107c5bc9d96f718d654df50e2705b98c03
---
M src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl
1 file changed, 124 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/41173/1

diff --git a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl
index 7cc9034..f631511 100644
--- a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl
+++ b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl
@@ -173,4 +173,128 @@
    		}
    	})
    }
+
+	Device(VCM0)
+	{
+		Name (_HID, "PRP0001")  /* _HID: Hardware ID */
+
+		Name (_UID, 0x00)  /* _UID: Unique ID */
+
+		Name (_DDN, "DW9768 VCM")  /* _DDN: DOS Device Name */
+
+		Method (_STA, 0, NotSerialized)  /* _STA: Status */
+		{
+			Return (0x0F)
+		}
+
+		Name (_CRS, ResourceTemplate ()  /* _CRS: Current Resource Settings */
+		{
+			I2cSerialBusV2 (0x000C, ControllerInitiated, 0x00061A80,
+			AddressingMode7Bit, "\_SB.PCI0.I2C3",
+			0x00, ResourceConsumer, , Exclusive,
+			)
+		})
+
+		Name (_DEP, Package (0x01)  /* _DEP: Dependencies */
+		{
+			CAM0
+		})
+
+		Name (_PR0, Package (0x01)  // _PR0: Power Resources for D0
+		{
+			RCPR
+		})
+
+		Name (_PR3, Package (0x01)  // _PR3: Power Resources for D3hot
+		{
+			RCPR
+		})
+
+		Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
+		{
+			ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), /* Device Properties for _DSD */
+			Package (0x01)
+			{
+				Package (0x02)
+				{
+					"compatible",
+					"dongwoon,dw9768"
+				}
+			}
+		})
+	}
+
+	Device (NVM0)
+	{
+		Name (_HID, "PRP0001")  // _HID: Hardware ID
+
+		Name (_UID, 0x01)  // _UID: Unique ID
+
+		Name (_DDN, "AT24 EEPROM")  // _DDN: DOS Device Name
+
+		Method (_STA, 0, NotSerialized)  // _STA: Status
+		{
+			Return (0x0F)
+		}
+
+		Name (_CRS, ResourceTemplate ()  // _CRS: Current Resource Settings
+		{
+			I2cSerialBusV2 (0x0058, ControllerInitiated, 0x00061A80,
+			AddressingMode7Bit, "\_SB.PCI0.I2C3",
+			0x00, ResourceConsumer, , Exclusive,
+			)
+		})
+
+		Name (_DEP, Package (0x01)  // _DEP: Dependencies
+		{
+			CAM0
+		})
+
+		Name (_PR0, Package (0x01)  // _PR0: Power Resources for D0
+		{
+			RCPR
+		})
+
+		Name (_PR3, Package (0x01)  // _PR3: Power Resources for D3hot
+		{
+			RCPR
+		})
+
+		Name (_DSD, Package (0x02)  // _DSD: Device-Specific Data
+		{
+			ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), /* Device Properties for _DSD */
+			Package (0x05)
+			{
+				Package (0x02)
+				{
+					"size",
+					0x2800
+				},
+
+				Package (0x02)
+				{
+					"pagesize",
+					One
+				},
+
+				Package (0x02)
+				{
+					"read-only",
+					One
+				},
+
+				Package (0x02)
+				{
+					"address-width",
+					0x0D
+				},
+
+				Package (0x02)
+				{
+					"compatible",
+					"atmel,24c1024"
+				}
+			}
+		})
+	}
 }

[Varshit B Pandya (Code Review)]

Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 5:

This change is ready for review.

[Varshit B Pandya (Code Review)]

Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41173/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41173/5//COMMIT_MSG@9 
PS5, Line 9: AT24
> Sorry for being ignorant, what is this needed for regarding the camera?

Hello Menzel,

AT24 is EEPROM on camera sensor.
I believe this is based on sensor implementation.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41173/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41173/5//COMMIT_MSG@9 
PS5, Line 9: Add support for DW9768 and AT24 on world facing cam
Please add a dot/period at the end.

https://review.coreboot.org/c/coreboot/+/41173/5//COMMIT_MSG@9 
PS5, Line 9: AT24
> Hello Menzel, […]

Thank you.

[Varshit B Pandya (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Maulik V Vaghela, Rizwan Qureshi, Aamir Bohra, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41173

to look at the new patch set (#6).

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

mb/google/dedede: Add VCM and NVM entry for OV8856 sensor

Add support for DW9768 and AT24 on world facing cam.

BUG=None
BRANCH=None
TEST=Build and able to see DW9768 and AT24 getting listed I2C3 lanes
and able to capture image using world facing camera.

Change-Id: I19e4a4107c5bc9d96f718d654df50e2705b98c03
Signed-off-by: Pandya, Varshit B 
---
M src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl
1 file changed, 134 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/41173/6

[Varshit B Pandya (Code Review)]

Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41173/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41173/5//COMMIT_MSG@9 
PS5, Line 9: Add support for DW9768 and AT24 on world facing cam
> Please add a dot/period at the end.

Done

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 6: Code-Review+1

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:

https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... 
PS6, Line 236: Device (NVM0)
No need to expose the NVM0 device through a package in CAM1's _DSD just like how it is done for VCM?

https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... 
PS6, Line 298: 0x0D
Not quite sure if the address lines are indexed from 0 to 0xD (i.e. 14 lines) or from 1 to 0xD (i.e. 13 lines). If 13 lines, is that sufficient to address the entire range 0x2800.

[Varshit B Pandya (Code Review)]

Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:

https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... 
PS6, Line 236: Device (NVM0)
> No need to expose the NVM0 device through a package in CAM1's _DSD just like how it is done for VCM?

The eeprom device will not be part of and recognized by V4L2 framework, 
the vcm attribute in sensor DSD section is to expose the VCM device to v4l2 framework, while eeprom will be registered as a standard nvmem device

[Varshit B Pandya (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Maulik V Vaghela, Rizwan Qureshi, Aamir Bohra, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41173

to look at the new patch set (#7).

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

mb/google/dedede: Add VCM and NVM entry for OV8856 sensor

Add support for DW9768 and AT24 on world facing cam.

BUG=None
BRANCH=None
TEST=Build and able to see DW9768 and AT24 getting listed I2C3 lanes
and able to capture image using world facing camera.

Change-Id: I19e4a4107c5bc9d96f718d654df50e2705b98c03
Signed-off-by: Pandya, Varshit B 
---
M src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl
1 file changed, 134 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/41173/7

[Varshit B Pandya (Code Review)]

Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:

https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... 
PS6, Line 298: 0x0D
> Not quite sure if the address lines are indexed from 0 to 0xD (i.e. 14 lines) or from 1 to 0xD (i.e. […]

Updated.

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 7: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:

https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... 
PS6, Line 236: Device (NVM0)
> The eeprom device will not be part of and recognized by V4L2 framework,  […]

Done

https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... 
PS6, Line 298: 0x0D
> Updated.

Done

[Maulik V Vaghela (Code Review)]

Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 7: Code-Review+2

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 7: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 7: Code-Review+1

(2 comments)

Is somebody working on unifying the camera ASL code, so it’s automatically generated for example? For example, besides some values, the structure is very similar to.

src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl

https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG@11 
PS7, Line 11: BUG=None
No bug?

https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG@14 
PS7, Line 14: and able to capture image using world facing camera.
Did the camera work before?

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:

https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... 
PS6, Line 236: Device (NVM0)
> Done

It’d be great if you mentioned this in the commit message.

[Varshit B Pandya (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Maulik V Vaghela, Paul Menzel, Rizwan Qureshi, Aamir Bohra, Ronak Kanabar, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41173

to look at the new patch set (#8).

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

mb/google/dedede: Add VCM and NVM entry for OV8856 sensor

Add DW9768 VCM device and add its entry in the OV8856's _DSD
to allow the V4L2 driver to use the VCM functionality.
Also add ACPI entries for AT24 NVM device, this will enumerated
as a generic NVM device and not part of the V4L2 framework.

BUG=None
BRANCH=None
TEST=Build and able to see DW9768 and AT24 getting listed I2C3 lanes
and able to capture image using world facing camera.

Change-Id: I19e4a4107c5bc9d96f718d654df50e2705b98c03
Signed-off-by: Pandya, Varshit B 
---
M src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl
1 file changed, 134 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/41173/8

[Varshit B Pandya (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Maulik V Vaghela, Paul Menzel, Rizwan Qureshi, Aamir Bohra, Ronak Kanabar, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41173

to look at the new patch set (#9).

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

mb/google/dedede: Add VCM and NVM entry for OV8856 sensor

Add DW9768 VCM device and add its entry in the OV8856's _DSD
to allow the V4L2 driver to use the VCM functionality.
Also add ACPI entries for AT24 NVM device, this will enumerated
as a generic NVM device and not part of the V4L2 framework.

BUG=b:155285666
BRANCH=None
TEST=Build and able to see DW9768 and AT24 getting listed I2C3 lanes
and able to capture image using world facing camera.

Change-Id: I19e4a4107c5bc9d96f718d654df50e2705b98c03
Signed-off-by: Pandya, Varshit B 
---
M src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl
1 file changed, 134 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/41173/9

[Varshit B Pandya (Code Review)]

Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 9:

(3 comments)
> Patch Set 7: Code-Review+1
>
> (2 comments)
>
> Is somebody working on unifying the camera ASL code, so it’s automatically generated for example? For example, besides some values, the structure is very similar to.
> src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl

Yes, here is the base patch https://review.coreboot.org/c/coreboot/+/41607

https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG@11 
PS7, Line 11: BUG=None
> No bug?

Updated.

https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG@14 
PS7, Line 14: and able to capture image using world facing camera.
> Did the camera work before?

This patch adds the VCM entries, earlier we were able to take raw capture. And now driver is able to control the VCM.

https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl:

https://review.coreboot.org/c/coreboot/+/41173/6/src/mainboard/google/dedede... 
PS6, Line 236: Device (NVM0)
> It’d be great if you mentioned this in the commit message.

okay.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG@14 
PS7, Line 14: and able to capture image using world facing camera.
> This patch adds the VCM entries, earlier we were able to take raw capture. […]

Can you please add that to the commit message?

[Varshit B Pandya (Code Review)]

Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41173/7//COMMIT_MSG@14 
PS7, Line 14: and able to capture image using world facing camera.
> Can you please add that to the commit message?

Yes, I have included it in the latest commit message.

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41173 )

Change subject: mb/google/dedede: Add VCM and NVM entry for OV8856 sensor
......................................................................

mb/google/dedede: Add VCM and NVM entry for OV8856 sensor

Add DW9768 VCM device and add its entry in the OV8856's _DSD
to allow the V4L2 driver to use the VCM functionality.
Also add ACPI entries for AT24 NVM device, this will enumerated
as a generic NVM device and not part of the V4L2 framework.

BUG=b:155285666
BRANCH=None
TEST=Build and able to see DW9768 and AT24 getting listed I2C3 lanes
and able to capture image using world facing camera.

Change-Id: I19e4a4107c5bc9d96f718d654df50e2705b98c03
Signed-off-by: Pandya, Varshit B 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41173
Tested-by: build bot (Jenkins) 
Reviewed-by: Karthik Ramasubramanian 
Reviewed-by: Maulik V Vaghela 
Reviewed-by: Aamir Bohra 
Reviewed-by: Paul Menzel 
---
M src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl
1 file changed, 134 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Aamir Bohra: Looks good to me, approved
  Maulik V Vaghela: Looks good to me, approved
  Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl
index 642502c..ef2a2a0 100644
--- a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl
+++ b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/acpi/cam1.asl
@@ -87,12 +87,21 @@
    		},

ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
-			Package (0x01)
+			Package (0x02)
    		{
    			Package (0x02)
    			{
    				"clock-frequency",
    				0x0124F800
+				},
+
+				Package (0x02)
+				{
+					"lens-focus",
+					Package (0x01)
+					{
+						VCM0
+					}
    			}
    		}
    	})
@@ -172,4 +181,128 @@
    		}
    	})
    }
+
+	Device(VCM0)
+	{
+		Name (_HID, "PRP0001")  /* _HID: Hardware ID */
+
+		Name (_UID, 0x00)  /* _UID: Unique ID */
+
+		Name (_DDN, "DW9768 VCM")  /* _DDN: DOS Device Name */
+
+		Method (_STA, 0, NotSerialized)  /* _STA: Status */
+		{
+			Return (0x0F)
+		}
+
+		Name (_CRS, ResourceTemplate ()  /* _CRS: Current Resource Settings */
+		{
+			I2cSerialBusV2 (0x000C, ControllerInitiated, 0x00061A80,
+			AddressingMode7Bit, "\_SB.PCI0.I2C3",
+			0x00, ResourceConsumer, , Exclusive,
+			)
+		})
+
+		Name (_DEP, Package (0x01)  /* _DEP: Dependencies */
+		{
+			CAM1
+		})
+
+		Name (_PR0, Package (0x01)  /* _PR0: Power Resources for D0 */
+		{
+			RCPR
+		})
+
+		Name (_PR3, Package (0x01)  /* _PR3: Power Resources for D3hot */
+		{
+			RCPR
+		})
+
+		Name (_DSD, Package (0x02)  /* _DSD: Device-Specific Data */
+		{
+			ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), /* Device Properties for _DSD */
+			Package (0x01)
+			{
+				Package (0x02)
+				{
+					"compatible",
+					"dongwoon,dw9768"
+				}
+			}
+		})
+	}
+
+	Device (NVM0)
+	{
+		Name (_HID, "PRP0001")  /* _HID: Hardware ID */
+
+		Name (_UID, 0x01)  /* _UID: Unique ID */
+
+		Name (_DDN, "AT24 EEPROM")  /* _DDN: DOS Device Name */
+
+		Method (_STA, 0, NotSerialized)  /* _STA: Status*/
+		{
+			Return (0x0F)
+		}
+
+		Name (_CRS, ResourceTemplate ()  /* _CRS: Current Resource Settings */
+		{
+			I2cSerialBusV2 (0x0058, ControllerInitiated, 0x00061A80,
+			AddressingMode7Bit, "\_SB.PCI0.I2C3",
+			0x00, ResourceConsumer, , Exclusive,
+			)
+		})
+
+		Name (_DEP, Package (0x01)  /* _DEP: Dependencies */
+		{
+			CAM1
+		})
+
+		Name (_PR0, Package (0x01)  /* _PR0: Power Resources for D0 */
+		{
+			RCPR
+		})
+
+		Name (_PR3, Package (0x01)  /* _PR3: Power Resources for D3hot */
+		{
+			RCPR
+		})
+
+		Name (_DSD, Package (0x02)  /* _DSD: Device-Specific Data */
+		{
+			ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), /* Device Properties for _DSD */
+			Package (0x05)
+			{
+				Package (0x02)
+				{
+					"size",
+					0x2800
+				},
+
+				Package (0x02)
+				{
+					"pagesize",
+					One
+				},
+
+				Package (0x02)
+				{
+					"read-only",
+					One
+				},
+
+				Package (0x02)
+				{
+					"address-width",
+					0x0E
+				},
+
+				Package (0x02)
+				{
+					"compatible",
+					"atmel,24c1024"
+				}
+			}
+		})
+	}
 }