Attention is currently required from: Shelley Chen, Ravi kumar, Furquan Shaikh, Paul Menzel, Julius Werner, Arthur Heymans, Kyösti Mälkki, mturney mturney.
Prasad Malisetty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53903 )
Change subject: libpayload: Add MMIO support in PCI lib
......................................................................
Patch Set 34:
(1 comment)
File payloads/libpayload/drivers/pci_ops.c:
https://review.coreboot.org/c/coreboot/+/53903/comment/baf44567_f920f256
PS28, Line 37: u32 devfn = ((dev >> 3) & 0x1f) | (dev & 0x07);
Similarly in Coreboot PCIe driver we have read/write_config function in which ATU configuration wi […]
Hi Furquan,
Thanks for the clarification.
Sure, if we can have a infrastructure to map coreboot callbacks from libpayload, it would be easy to implement map_bus function for all available buses instead of specific bus case.
Please let me know once the changes are ready. I will do the same for PCI library case.
I have addressed all existing comments on this change. due to some unplanned activities, couldn't post the changes in time. I will share new version changes in day or 2.
Thanks
-Prasad
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53903
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cfb95e31b7ee984ee0c2e7586e6caeecd7deadd
Gerrit-Change-Number: 53903
Gerrit-PatchSet: 34
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Thu, 02 Sep 2021 03:46:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-MessageType: comment