Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 )
Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops
......................................................................
Patch Set 6:
(2 comments)
File src/ec/clevo/it5570e/commands.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/77c573af_2358fc2e
PS4, Line 41: while (recv_ec_data() != '$');
check the previous push. […]
Looks like CB:69077 is fine :O Personally, I still prefer the variant without `do {}`. I'll prepare a RFC change for the linter. Let's see what others think :-)
File src/ec/clevo/it5570e/commands.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/cf35d195_3a9d098e
PS6, Line 120: printk(BIOS_ERR, "EC: invalid flexicharger settings: start/stop > 100%%\n");
Should the parameters be sanitized?
ouch, the plan was to just return bc I'm not a fan of trying to guess what the user intended. will fix
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68791
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8c0bee9002ad9edcd10c83b775fc723744caaa0
Gerrit-Change-Number: 68791
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 02 Nov 2022 09:08:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment