Change in ...coreboot[master]: soc/intel/cannonlake: Add Whiskeylake SoC kconfig

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31133 )

Change subject: soc/intel/cannonlake: Add Whiskeylake SoC kconfig
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/#/c/31133/8/src/soc/intel/cannonlake/Kconfig 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/#/c/31133/8/src/soc/intel/cannonlake/Kconfig@267 
PS8, Line 267: SOC_INTEL_COFFEELAKE || SOC_INTEL_WHISKEYLAKE
> SOC_INTEL_COMMON_CANNONLAKE_BASE? […]

yes check comment here

https://review.coreboot.org/#/c/31133/7..8/src/soc/intel/cannonlake/Kconfig

Furquan Shaikh
12:52 AM
Have to be careful about this. If SOC_INTEL_COMMON_CANNONLAKE_BASE is expected to be selected by all new SoCs using CNL PCH, then you need to ensure that they use the right FSP headers and paths.

Subrata Banik
12:56 AM
this may not holds true for CML because that will have CML FSP package, so i have to add CFL and WHL Kconfig specifically here