HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43939 )
Change subject: sb/amd/agesa/hudson: Add missing '#include <stddef.h>' ......................................................................
sb/amd/agesa/hudson: Add missing '#include <stddef.h>'
size_t needs <stddef.h>.
Change-Id: I9ccf526df44dbad8568f75bd0506ac686fdb7860 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/amd/agesa/hudson/smbus_spd.c M src/southbridge/amd/agesa/hudson/spi.c 2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/43939/1
diff --git a/src/southbridge/amd/agesa/hudson/smbus_spd.c b/src/southbridge/amd/agesa/hudson/smbus_spd.c index e0f36ca..7dcbbf9 100644 --- a/src/southbridge/amd/agesa/hudson/smbus_spd.c +++ b/src/southbridge/amd/agesa/hudson/smbus_spd.c @@ -4,6 +4,7 @@ #include <device/pci_def.h> #include <device/device.h> #include <console/console.h> +#include <stddef.h> /* warning: Porting.h includes an open #pragma pack(1) */ #include <Porting.h> #include <AGESA.h> diff --git a/src/southbridge/amd/agesa/hudson/spi.c b/src/southbridge/amd/agesa/hudson/spi.c index cce11dc..b2f9ff2 100644 --- a/src/southbridge/amd/agesa/hudson/spi.c +++ b/src/southbridge/amd/agesa/hudson/spi.c @@ -1,4 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ + #include <stdint.h> #include <device/mmio.h> #include <console/console.h> @@ -7,6 +8,7 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> +#include <stddef.h>
#include <Proc/Fch/FchPlatform.h>
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43939 )
Change subject: sb/amd/agesa/hudson: Add missing '#include <stddef.h>' ......................................................................
Patch Set 1:
(2 comments)
I've added comments to make the review easy
https://review.coreboot.org/c/coreboot/+/43939/1/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/smbus_spd.c:
https://review.coreboot.org/c/coreboot/+/43939/1/src/southbridge/amd/agesa/h... PS1, Line 124: size_t stddef
https://review.coreboot.org/c/coreboot/+/43939/1/src/southbridge/amd/agesa/h... File src/southbridge/amd/agesa/hudson/spi.c:
https://review.coreboot.org/c/coreboot/+/43939/1/src/southbridge/amd/agesa/h... PS1, Line 76: size_t stddef
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43939 )
Change subject: sb/amd/agesa/hudson: Add missing '#include <stddef.h>' ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43939 )
Change subject: sb/amd/agesa/hudson: Add missing '#include <stddef.h>' ......................................................................
sb/amd/agesa/hudson: Add missing '#include <stddef.h>'
size_t needs <stddef.h>.
Change-Id: I9ccf526df44dbad8568f75bd0506ac686fdb7860 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/43939 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/amd/agesa/hudson/smbus_spd.c M src/southbridge/amd/agesa/hudson/spi.c 2 files changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/southbridge/amd/agesa/hudson/smbus_spd.c b/src/southbridge/amd/agesa/hudson/smbus_spd.c index e0f36ca..7dcbbf9 100644 --- a/src/southbridge/amd/agesa/hudson/smbus_spd.c +++ b/src/southbridge/amd/agesa/hudson/smbus_spd.c @@ -4,6 +4,7 @@ #include <device/pci_def.h> #include <device/device.h> #include <console/console.h> +#include <stddef.h> /* warning: Porting.h includes an open #pragma pack(1) */ #include <Porting.h> #include <AGESA.h> diff --git a/src/southbridge/amd/agesa/hudson/spi.c b/src/southbridge/amd/agesa/hudson/spi.c index cce11dc..b2f9ff2 100644 --- a/src/southbridge/amd/agesa/hudson/spi.c +++ b/src/southbridge/amd/agesa/hudson/spi.c @@ -1,4 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ + #include <stdint.h> #include <device/mmio.h> #include <console/console.h> @@ -7,6 +8,7 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> +#include <stddef.h>
#include <Proc/Fch/FchPlatform.h>
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)