Attention is currently required from: Jamie Chen, Tim Wawrzynczak, Shou-Chieh Hsu, Leo Chou.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68095 )
Change subject: mb/google/nissa/pujjo: Tuning eMMC DLL value for eMMC initialization error
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68095/comment/de2d92e6_aab5505e
PS1, Line 12: "Use the value to boot on Pujjo successfully."
nti: remove the quotes
File src/mainboard/google/brya/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/68095/comment/44270ea3_40eba404
PS1, Line 254: select SOC_INTEL_COMMON_MMC_OVERRIDE
Don't need this because it's already selected for the baseboard.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68095
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic36c817fa546741e394668297ca43db3a45ee105
Gerrit-Change-Number: 68095
Gerrit-PatchSet: 1
Gerrit-Owner: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-CC: Jynn Chen
jynn.chen@lcfc.corp-partner.google.com
Gerrit-CC: Leanne1 Chen
leanne1.chen@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Tue, 04 Oct 2022 22:16:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment