Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30872 )
Change subject: [WIP] arch/x86: Add symbols for CAR MTRRs in linker script
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/30872/5/src/arch/x86/car.ld
File src/arch/x86/car.ld:
https://review.coreboot.org/c/coreboot/+/30872/5/src/arch/x86/car.ld@90
PS5, Line 90: _xip_mtrr_mask = ~(MAX(4096, _xip_program_sz_log2) - 1);
There's only a few chipsets that would benefit from these symbols. […]
The references are in couple cache_as_ram.S files and I don't have a single good guard ready at hand. It would be either new Kconfig or logical or of selected CPU_INTEL_SLOT_x and CPU_INTEL_SOCKET_x.
Would you accept _booblock_mtrr_mask exposed unconditionally?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30872
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2fef3546d2bfea2d4d8f87aaf8376e5566fd6aaa
Gerrit-Change-Number: 30872
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 May 2020 01:46:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment