Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39298 )
Change subject: util/autoport: Remove redundant comment ......................................................................
util/autoport: Remove redundant comment
Nobody needs "LPC bridge PCI-LPC bridge".
Change-Id: Iac833d4fa34b00d89bdfc9aeb06a96583840b900 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/autoport/bd82x6x.go 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/39298/1
diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go index 3ad212b..87e7584 100644 --- a/util/autoport/bd82x6x.go +++ b/util/autoport/bd82x6x.go @@ -277,7 +277,7 @@ }
PutPCIChip(addr, cur) - PutPCIDevParent(addr, "PCI-LPC bridge", "lpc") + PutPCIDevParent(addr, "", "lpc")
DSDTIncludes = append(DSDTIncludes, DSDTInclude{ File: "southbridge/intel/common/acpi/platform.asl",
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39298 )
Change subject: util/autoport: Remove redundant comment ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39298 )
Change subject: util/autoport: Remove redundant comment ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39298 )
Change subject: util/autoport: Remove redundant comment ......................................................................
util/autoport: Remove redundant comment
Nobody needs "LPC bridge PCI-LPC bridge".
Change-Id: Iac833d4fa34b00d89bdfc9aeb06a96583840b900 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39298 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/autoport/bd82x6x.go 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/util/autoport/bd82x6x.go b/util/autoport/bd82x6x.go index 3ad212b..87e7584 100644 --- a/util/autoport/bd82x6x.go +++ b/util/autoport/bd82x6x.go @@ -277,7 +277,7 @@ }
PutPCIChip(addr, cur) - PutPCIDevParent(addr, "PCI-LPC bridge", "lpc") + PutPCIDevParent(addr, "", "lpc")
DSDTIncludes = append(DSDTIncludes, DSDTInclude{ File: "southbridge/intel/common/acpi/platform.asl",
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39298 )
Change subject: util/autoport: Remove redundant comment ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1161 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1160 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1159
Please note: This test is under development and might not be accurate at all!