build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62090 )
Change subject: nb/amd/amdfam10: Add bootblock intialization ......................................................................
Patch Set 1:
(43 comments)
File src/northbridge/amd/amdfam10/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/dab8af2e_85c621d2 PS1, Line 70: id = pci_io_read_config32(PCI_DEV(0,0,0), PCI_VENDOR_ID); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/97edb528_27530231 PS1, Line 70: id = pci_io_read_config32(PCI_DEV(0,0,0), PCI_VENDOR_ID); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/1455a701_e7e8eb0c PS1, Line 72: if (((id & 0xffff) == 0x0000) || ((id & 0xffff) == 0xffff) || that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/963a0d3c_8ff97f92 PS1, Line 79: hdr_type = pci_io_read_config8(PCI_DEV(0,0,0), PCI_HEADER_TYPE); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/858a3bca_d42c6561 PS1, Line 79: hdr_type = pci_io_read_config8(PCI_DEV(0,0,0), PCI_HEADER_TYPE); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/41eb6186_9016c807 PS1, Line 83: if ((hdr_type == PCI_HEADER_TYPE_NORMAL) || that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/61a521d8_9205d443 PS1, Line 86: pos = pci_io_read_config8(PCI_DEV(0,0,0), PCI_CAPABILITY_LIST); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/93b873ee_ea41b576 PS1, Line 86: pos = pci_io_read_config8(PCI_DEV(0,0,0), PCI_CAPABILITY_LIST); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/552cd086_3c521b74 PS1, Line 90: cap = pci_io_read_config8(PCI_DEV(0,0,0), pos + PCI_CAP_LIST_ID); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/bc5d4223_e9df5b8d PS1, Line 90: cap = pci_io_read_config8(PCI_DEV(0,0,0), pos + PCI_CAP_LIST_ID); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/c8e1e235_7a62cd24 PS1, Line 96: flags = pci_io_read_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/273170b6_ef807124 PS1, Line 96: flags = pci_io_read_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/c6fec73a_cf1bdc14 PS1, Line 96: flags = pci_io_read_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/c42a80f4_96e30bb3 PS1, Line 97: pci_io_write_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS, flags); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/26accdcb_b73f166f PS1, Line 97: pci_io_write_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS, flags); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/fb3cada1_041e9621 PS1, Line 97: pci_io_write_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS, flags); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/a2c677a3_d436429d PS1, Line 98: flags = pci_io_read_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/04945119_9751d8b9 PS1, Line 98: flags = pci_io_read_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/21e2f5c9_1bdf9d55 PS1, Line 98: flags = pci_io_read_config16(PCI_DEV(0,0,0), pos + PCI_CAP_FLAGS); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/67417cb3_19488357 PS1, Line 106: if (!end_used) { Too many leading tabs - consider code refactoring
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/e6e0c56b_c4bbe6cf PS1, Line 107: next_unitid = CONFIG_HT_CHAIN_END_UNITID_BASE; line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/130a43cc_a2ed08b1 PS1, Line 109: } else { Too many leading tabs - consider code refactoring
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/af6f0d1b_2faa3636 PS1, Line 127: pci_io_write_config16(PCI_DEV(0, 0, 0), pos + PCI_CAP_FLAGS, flags); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/5bba2b03_55b51103 PS1, Line 130: ctrl_off = ((flags >> 10) & 1)? spaces required around that '?' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/5d71a55d_7a3eae5f PS1, Line 134: ctrl = pci_io_read_config16(devx, pos + ctrl_off); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/0abf8569_bc33dd6a PS1, Line 135: /* Is this the end of the hypertransport chain? */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/c23b5862_41e11154 PS1, Line 136: if (ctrl & (1 << 6)) { Too many leading tabs - consider code refactoring
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/808260d7_bcefaf68 PS1, Line 136: if (ctrl & (1 << 6)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/4ea613b5_166b29e0 PS1, Line 140: if (ctrl & ((1 << 4) | (1 << 8))) { Too many leading tabs - consider code refactoring
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/5092e9db_caac655e PS1, Line 142: * Either the link has failed, or we have line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/d11ab603_2f56b809 PS1, Line 145: * retrain, so lets knock it down and see line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/0f490755_2089e45c PS1, Line 148: ctrl |= ((1 << 4) | (1 <<8)); // Link fail + Crc line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/46571ce3_45ce5f5f PS1, Line 148: ctrl |= ((1 << 4) | (1 <<8)); // Link fail + Crc need consistent spacing around '<<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/2a12a9e1_a5e6734d PS1, Line 149: pci_io_write_config16(devx, pos + ctrl_off, ctrl); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/401a24f3_11b2f23b PS1, Line 150: ctrl = pci_io_read_config16(devx, pos + ctrl_off); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/5dc11e70_76588abf PS1, Line 151: if (ctrl & ((1 << 4) | (1 << 8))) { Too many leading tabs - consider code refactoring
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/6bb90ab7_96fc6b84 PS1, Line 165: out: ; space prohibited before semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/49654934_a5c81b66 PS1, Line 167: if ((ht_dev_num > 1) && (real_last_unitid != CONFIG_HT_CHAIN_END_UNITID_BASE) && !end_used) { line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/b1f3443a_19be1ca5 PS1, Line 169: flags = pci_io_read_config16(PCI_DEV(0,real_last_unitid,0), real_last_pos + PCI_CAP_FLAGS); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/b5bbc4b3_0bac699d PS1, Line 169: flags = pci_io_read_config16(PCI_DEV(0,real_last_unitid,0), real_last_pos + PCI_CAP_FLAGS); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/9140ec0d_b8c94e20 PS1, Line 169: flags = pci_io_read_config16(PCI_DEV(0,real_last_unitid,0), real_last_pos + PCI_CAP_FLAGS); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/36a4d1e4_6f6ee216 PS1, Line 172: pci_io_write_config16(PCI_DEV(0, real_last_unitid, 0), real_last_pos + PCI_CAP_FLAGS, flags); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-141267): https://review.coreboot.org/c/coreboot/+/62090/comment/1765678c_c3335eac PS1, Line 179: void bootblock_early_northbridge_init(void) { open brace '{' following function definitions go on the next line
-
build bot (Jenkins) (Code Review)