Attention is currently required from: Hung-Te Lin, Jakub Czapiga, Julius Werner, Jianjun Wang. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63494 )
Change subject: coreboot_tables: Convert 'struct lb_uint64' to lb_uint64_t ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63494/comment/f76bcdf4_e978099f PS3, Line 7: Convert 'struct lb_uint64' to Replace '...' with
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/63494/comment/a08b836d_bf0ff778 PS3, Line 97: /* Since coreboot is usually compiled 32bit, gcc will align 64bit : * types to 32bit boundaries. If the coreboot table is dumped on a : * 64bit system, a uint64_t would be aligned to 64bit boundaries, : * breaking the table format. : * : * lb_uint64 will keep 64bit coreboot table values aligned to 32bit : * to ensure compatibility. They can be accessed with the two functions : * below: unpack_lb64() and pack_lb64() It's still nice to have this comment, with some modification.
-
Yu-Ping Wu (Code Review)