Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31933 )
Change subject: util/sconfig: Expose usable PCI and PNP device names ......................................................................
Patch Set 6: Code-Review+1
(4 comments)
looks good to me, but haven't looked closely enough into this to +2 it
https://review.coreboot.org/c/coreboot/+/31933/3/util/sconfig/main.c File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/31933/3/util/sconfig/main.c@847 PS3, Line 847: pass2
maybe use a more descriptive name for the pass?
Done
https://review.coreboot.org/c/coreboot/+/31933/3/util/sconfig/main.c@852 PS3, Line 852: ptr->path_a, ptr->path_b
not related to this patch, but i find the struct element path_a and path_b very undescriptive
this is out of the scope of this patch , but would imho still be a good idea
https://review.coreboot.org/c/coreboot/+/31933/4/util/sconfig/main.c File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/31933/4/util/sconfig/main.c@847 PS4, Line 847: pass2
expose_device_names or something like that?
Done
https://review.coreboot.org/c/coreboot/+/31933/4/util/sconfig/main.c@1357 PS4, Line 1357: pass 2
ditto?
Done
-
Felix Held (Code Review)