Change in coreboot[master]: mb/*/*/gpio: Remove null-initialized members

[Peter Lemenkov (Code Review)]

Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35900 )

Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................

mb/*/*/gpio: Remove null-initialized members

Made with this oneliner:

$ find src/mainboard/  -type f -name gpio.c -print -exec sed -i -e '/^\s*.gpio[0-9]+\s*=\s*(GPIO_MODE_NATIVE|GPIO_DIR_OUTPUT|GPIO_NO_INVERT|GPIO_LEVEL_LOW|GPIO_NO_BLINK|GPIO_RESET_PWROK)\s*$/d' {} ;

It didn't touch lines with comments.

Change-Id: I2799293585bcfcf41c93a9dbe358cd806f9374f5
Signed-off-by: Peter Lemenkov 
---
M src/mainboard/apple/macbook21/gpio.c
M src/mainboard/apple/macbookair4_2/gpio.c
M src/mainboard/asrock/b75pro3-m/gpio.c
M src/mainboard/asrock/g41c-gs/variants/g41c-gs-r2/gpio.c
M src/mainboard/asrock/g41c-gs/variants/g41c-gs/gpio.c
M src/mainboard/asrock/g41c-gs/variants/g41m-gs/gpio.c
M src/mainboard/asrock/g41c-gs/variants/g41m-s3/gpio.c
M src/mainboard/asrock/g41c-gs/variants/g41m-vs3-r2/gpio.c
M src/mainboard/asrock/h81m-hds/gpio.c
M src/mainboard/asus/h61m-cs/gpio.c
M src/mainboard/asus/maximus_iv_gene-z/gpio.c
M src/mainboard/asus/p5gc-mx/gpio.c
M src/mainboard/asus/p5qc/gpio.c
M src/mainboard/asus/p5qc/variants/p5ql_pro/gpio.c
M src/mainboard/asus/p5qpl-am/variants/p5g41t-m_lx/gpio.c
M src/mainboard/asus/p5qpl-am/variants/p5qpl-am/gpio.c
M src/mainboard/asus/p8h61-m_lx/gpio.c
M src/mainboard/asus/p8h61-m_pro/gpio.c
M src/mainboard/asus/p8z77-m_pro/gpio.c
M src/mainboard/compulab/intense_pc/gpio.c
M src/mainboard/foxconn/d41s/gpio.c
M src/mainboard/foxconn/g41s-k/gpio.c
M src/mainboard/getac/p470/gpio.c
M src/mainboard/gigabyte/ga-945gcm-s2l/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3h/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/gpio.c
M src/mainboard/gigabyte/ga-g41m-es2l/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/gpio.c
M src/mainboard/google/link/gpio.c
M src/mainboard/google/parrot/gpio.c
M src/mainboard/google/stout/gpio.c
M src/mainboard/hp/2570p/gpio.c
M src/mainboard/hp/2760p/gpio.c
M src/mainboard/hp/8460p/gpio.c
M src/mainboard/hp/8470p/gpio.c
M src/mainboard/hp/8770w/gpio.c
M src/mainboard/hp/compaq_8200_elite_sff/gpio.c
M src/mainboard/hp/folio_9470m/gpio.c
M src/mainboard/hp/revolve_810_g1/gpio.c
M src/mainboard/hp/z220_sff_workstation/gpio.c
M src/mainboard/ibase/mb899/gpio.c
M src/mainboard/intel/d510mo/gpio.c
M src/mainboard/intel/d945gclf/gpio.c
M src/mainboard/intel/dcp847ske/gpio.c
M src/mainboard/intel/dg41wv/gpio.c
M src/mainboard/intel/dg43gt/gpio.c
M src/mainboard/kontron/986lcd-m/gpio.c
M src/mainboard/lenovo/l520/gpio.c
M src/mainboard/lenovo/s230u/gpio.c
M src/mainboard/lenovo/t400/variants/r500/gpio.c
M src/mainboard/lenovo/t400/variants/t400/gpio.c
M src/mainboard/lenovo/t420/gpio.c
M src/mainboard/lenovo/t420s/gpio.c
M src/mainboard/lenovo/t430s/variants/t430s/gpio.c
M src/mainboard/lenovo/t430s/variants/t431s/gpio.c
M src/mainboard/lenovo/t520/variants/t520/gpio.c
M src/mainboard/lenovo/t520/variants/w520/gpio.c
M src/mainboard/lenovo/t530/variants/t530/gpio.c
M src/mainboard/lenovo/t530/variants/w530/gpio.c
M src/mainboard/lenovo/t60/gpio.c
M src/mainboard/lenovo/thinkcentre_a58/gpio.c
M src/mainboard/lenovo/x131e/gpio.c
M src/mainboard/lenovo/x1_carbon_gen1/gpio.c
M src/mainboard/lenovo/x200/gpio.c
M src/mainboard/lenovo/x201/gpio.c
M src/mainboard/lenovo/x220/variants/x1/gpio.c
M src/mainboard/lenovo/x220/variants/x220/gpio.c
M src/mainboard/lenovo/x230/gpio.c
M src/mainboard/lenovo/x60/gpio.c
M src/mainboard/msi/ms7707/gpio.c
M src/mainboard/packardbell/ms2290/gpio.c
M src/mainboard/roda/rk886ex/gpio.c
M src/mainboard/roda/rk9/gpio.c
M src/mainboard/roda/rv11/gpio.c
M src/mainboard/samsung/lumpy/gpio.c
M src/mainboard/samsung/stumpy/gpio.c
M src/mainboard/sapphire/pureplatinumh61/gpio.c
M src/mainboard/supermicro/x10slm-f/gpio.c
79 files changed, 0 insertions(+), 4,228 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35900/1

[Peter Lemenkov (Code Review)]

Hello Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, Angel Pons, Tristan Corrick,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35900

to look at the new patch set (#2).

Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................

mb/*/*/gpio: Remove null-initialized members

Made with this oneliner:

$ find src/mainboard/  -type f -name gpio.c -print -exec sed -i -e '/^\s*.gpio[0-9]+\s*=\s*(GPIO_MODE_NATIVE|GPIO_DIR_OUTPUT|GPIO_NO_INVERT|GPIO_LEVEL_LOW|GPIO_NO_BLINK|GPIO_RESET_PWROK)\s*$/d' {} ;

It didn't touch lines with comments since they might be useful.

See also commit 6752b6151 with Change-Id
I4e07bd755ca4a65b76c69625d235a879fe7b43cb.

Change-Id: I2799293585bcfcf41c93a9dbe358cd806f9374f5
Signed-off-by: Peter Lemenkov 
---
M src/mainboard/apple/macbook21/gpio.c
M src/mainboard/apple/macbookair4_2/gpio.c
M src/mainboard/asrock/b75pro3-m/gpio.c
M src/mainboard/asrock/g41c-gs/variants/g41c-gs-r2/gpio.c
M src/mainboard/asrock/g41c-gs/variants/g41c-gs/gpio.c
M src/mainboard/asrock/g41c-gs/variants/g41m-gs/gpio.c
M src/mainboard/asrock/g41c-gs/variants/g41m-s3/gpio.c
M src/mainboard/asrock/g41c-gs/variants/g41m-vs3-r2/gpio.c
M src/mainboard/asrock/h81m-hds/gpio.c
M src/mainboard/asus/h61m-cs/gpio.c
M src/mainboard/asus/maximus_iv_gene-z/gpio.c
M src/mainboard/asus/p5gc-mx/gpio.c
M src/mainboard/asus/p5qc/gpio.c
M src/mainboard/asus/p5qc/variants/p5ql_pro/gpio.c
M src/mainboard/asus/p5qpl-am/variants/p5g41t-m_lx/gpio.c
M src/mainboard/asus/p5qpl-am/variants/p5qpl-am/gpio.c
M src/mainboard/asus/p8h61-m_lx/gpio.c
M src/mainboard/asus/p8h61-m_pro/gpio.c
M src/mainboard/asus/p8z77-m_pro/gpio.c
M src/mainboard/compulab/intense_pc/gpio.c
M src/mainboard/foxconn/d41s/gpio.c
M src/mainboard/foxconn/g41s-k/gpio.c
M src/mainboard/getac/p470/gpio.c
M src/mainboard/gigabyte/ga-945gcm-s2l/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3h/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/gpio.c
M src/mainboard/gigabyte/ga-g41m-es2l/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/gpio.c
M src/mainboard/google/link/gpio.c
M src/mainboard/google/parrot/gpio.c
M src/mainboard/google/stout/gpio.c
M src/mainboard/hp/2570p/gpio.c
M src/mainboard/hp/2760p/gpio.c
M src/mainboard/hp/8460p/gpio.c
M src/mainboard/hp/8470p/gpio.c
M src/mainboard/hp/8770w/gpio.c
M src/mainboard/hp/compaq_8200_elite_sff/gpio.c
M src/mainboard/hp/folio_9470m/gpio.c
M src/mainboard/hp/revolve_810_g1/gpio.c
M src/mainboard/hp/z220_sff_workstation/gpio.c
M src/mainboard/ibase/mb899/gpio.c
M src/mainboard/intel/d510mo/gpio.c
M src/mainboard/intel/d945gclf/gpio.c
M src/mainboard/intel/dcp847ske/gpio.c
M src/mainboard/intel/dg41wv/gpio.c
M src/mainboard/intel/dg43gt/gpio.c
M src/mainboard/kontron/986lcd-m/gpio.c
M src/mainboard/lenovo/l520/gpio.c
M src/mainboard/lenovo/s230u/gpio.c
M src/mainboard/lenovo/t400/variants/r500/gpio.c
M src/mainboard/lenovo/t400/variants/t400/gpio.c
M src/mainboard/lenovo/t420/gpio.c
M src/mainboard/lenovo/t420s/gpio.c
M src/mainboard/lenovo/t430s/variants/t430s/gpio.c
M src/mainboard/lenovo/t430s/variants/t431s/gpio.c
M src/mainboard/lenovo/t520/variants/t520/gpio.c
M src/mainboard/lenovo/t520/variants/w520/gpio.c
M src/mainboard/lenovo/t530/variants/t530/gpio.c
M src/mainboard/lenovo/t530/variants/w530/gpio.c
M src/mainboard/lenovo/t60/gpio.c
M src/mainboard/lenovo/thinkcentre_a58/gpio.c
M src/mainboard/lenovo/x131e/gpio.c
M src/mainboard/lenovo/x1_carbon_gen1/gpio.c
M src/mainboard/lenovo/x200/gpio.c
M src/mainboard/lenovo/x201/gpio.c
M src/mainboard/lenovo/x220/variants/x1/gpio.c
M src/mainboard/lenovo/x220/variants/x220/gpio.c
M src/mainboard/lenovo/x230/gpio.c
M src/mainboard/lenovo/x60/gpio.c
M src/mainboard/msi/ms7707/gpio.c
M src/mainboard/packardbell/ms2290/gpio.c
M src/mainboard/roda/rk886ex/gpio.c
M src/mainboard/roda/rk9/gpio.c
M src/mainboard/roda/rv11/gpio.c
M src/mainboard/samsung/lumpy/gpio.c
M src/mainboard/samsung/stumpy/gpio.c
M src/mainboard/sapphire/pureplatinumh61/gpio.c
M src/mainboard/supermicro/x10slm-f/gpio.c
79 files changed, 0 insertions(+), 4,228 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35900/2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35900 )

Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................

Patch Set 2: Code-Review+1

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35900 )

Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................

Patch Set 2: Code-Review+1

Tested how?

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35900 )

Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................

Patch Set 2: Code-Review-1

for the NATIVE/GPIO, sure
For INPUT/OUTPUT and certainly for HIGH/LOW on OUTPUT I don't think this is an improvement. For NO_INVERT, NO_BLINK and RESET_PWROK, I also think it's fine.

[Peter Lemenkov (Code Review)]

Hello Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, HAOUAS Elyes, Angel Pons, Arthur Heymans, Tristan Corrick, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35900

to look at the new patch set (#3).

Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................

mb/*/*/gpio: Remove null-initialized members

Made with this oneliner:

$ find src/mainboard/  -type f -name gpio.c -print -exec sed -i -e '/^\s*.gpio[0-9]+\s*=\s*(GPIO_MODE_NATIVE|GPIO_NO_INVERT|GPIO_NO_BLINK|GPIO_RESET_PWROK),\s*$/d' {} ;

It didn't touch lines with comments since they might be useful.

See also commit 6752b6151 with Change-Id
I4e07bd755ca4a65b76c69625d235a879fe7b43cb.

Change-Id: I2799293585bcfcf41c93a9dbe358cd806f9374f5
Signed-off-by: Peter Lemenkov 
---
M src/mainboard/apple/macbookair4_2/gpio.c
M src/mainboard/asrock/b75pro3-m/gpio.c
M src/mainboard/asus/h61m-cs/gpio.c
M src/mainboard/asus/p5gc-mx/gpio.c
M src/mainboard/asus/p5qpl-am/variants/p5g41t-m_lx/gpio.c
M src/mainboard/asus/p8h61-m_pro/gpio.c
M src/mainboard/asus/p8z77-m_pro/gpio.c
M src/mainboard/compulab/intense_pc/gpio.c
M src/mainboard/foxconn/d41s/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3h/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/gpio.c
M src/mainboard/hp/2570p/gpio.c
M src/mainboard/hp/2760p/gpio.c
M src/mainboard/hp/8460p/gpio.c
M src/mainboard/hp/8470p/gpio.c
M src/mainboard/hp/8770w/gpio.c
M src/mainboard/hp/compaq_8200_elite_sff/gpio.c
M src/mainboard/hp/folio_9470m/gpio.c
M src/mainboard/hp/revolve_810_g1/gpio.c
M src/mainboard/hp/z220_sff_workstation/gpio.c
M src/mainboard/intel/dcp847ske/gpio.c
M src/mainboard/lenovo/s230u/gpio.c
M src/mainboard/lenovo/t420/gpio.c
M src/mainboard/lenovo/t420s/gpio.c
M src/mainboard/lenovo/t430s/variants/t430s/gpio.c
M src/mainboard/lenovo/t430s/variants/t431s/gpio.c
M src/mainboard/lenovo/t520/variants/t520/gpio.c
M src/mainboard/lenovo/t520/variants/w520/gpio.c
M src/mainboard/lenovo/t530/variants/t530/gpio.c
M src/mainboard/lenovo/t530/variants/w530/gpio.c
M src/mainboard/lenovo/x1_carbon_gen1/gpio.c
M src/mainboard/lenovo/x201/gpio.c
M src/mainboard/lenovo/x220/variants/x1/gpio.c
M src/mainboard/lenovo/x220/variants/x220/gpio.c
M src/mainboard/lenovo/x230/gpio.c
M src/mainboard/msi/ms7707/gpio.c
M src/mainboard/roda/rv11/gpio.c
M src/mainboard/samsung/lumpy/gpio.c
M src/mainboard/samsung/stumpy/gpio.c
M src/mainboard/sapphire/pureplatinumh61/gpio.c
42 files changed, 0 insertions(+), 2,114 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35900/3

[Peter Lemenkov (Code Review)]

Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35900 )

Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................

Patch Set 2:
> Patch Set 2: Code-Review-1
>
> for the NATIVE/GPIO, sure
> For INPUT/OUTPUT and certainly for HIGH/LOW on OUTPUT I don't think this is an improvement. For NO_INVERT, NO_BLINK and RESET_PWROK, I also think it's fine.

Done. I removed only GPIO_MODE_NATIVE, GPIO_NO_INVERT, GPIO_NO_BLINK, GPIO_RESET_PWROK.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35900 )

Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................

Patch Set 3: Code-Review+1

[Peter Lemenkov (Code Review)]

Hello Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, HAOUAS Elyes, Angel Pons, Arthur Heymans, Tristan Corrick, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35900

to look at the new patch set (#4).

Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................

mb/*/*/gpio: Remove null-initialized members

Made with this oneliner:

$ find src/mainboard/  -type f -name gpio.c -print -exec sed -i -e '/^\s*.gpio[0-9]+\s*=\s*(GPIO_MODE_NATIVE|GPIO_NO_INVERT|GPIO_NO_BLINK|GPIO_RESET_PWROK),\s*$/d' {} ;

It didn't touch lines with comments since they might be useful.

See also commit 6752b6151 with Change-Id
I4e07bd755ca4a65b76c69625d235a879fe7b43cb.

Change-Id: I2799293585bcfcf41c93a9dbe358cd806f9374f5
Signed-off-by: Peter Lemenkov 
---
M src/mainboard/apple/macbookair4_2/gpio.c
M src/mainboard/asrock/b75pro3-m/gpio.c
M src/mainboard/asus/h61m-cs/gpio.c
M src/mainboard/asus/p5gc-mx/gpio.c
M src/mainboard/asus/p5qpl-am/variants/p5g41t-m_lx/gpio.c
M src/mainboard/asus/p8h61-m_pro/gpio.c
M src/mainboard/asus/p8z77-m_pro/gpio.c
M src/mainboard/compulab/intense_pc/gpio.c
M src/mainboard/foxconn/d41s/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3h/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/gpio.c
M src/mainboard/hp/2570p/gpio.c
M src/mainboard/hp/2760p/gpio.c
M src/mainboard/hp/8460p/gpio.c
M src/mainboard/hp/8470p/gpio.c
M src/mainboard/hp/8770w/gpio.c
M src/mainboard/hp/compaq_8200_elite_sff/gpio.c
M src/mainboard/hp/folio_9470m/gpio.c
M src/mainboard/hp/revolve_810_g1/gpio.c
M src/mainboard/hp/z220_sff_workstation/gpio.c
M src/mainboard/intel/dcp847ske/gpio.c
M src/mainboard/lenovo/s230u/gpio.c
M src/mainboard/lenovo/t410/gpio.c
M src/mainboard/lenovo/t420/gpio.c
M src/mainboard/lenovo/t420s/gpio.c
M src/mainboard/lenovo/t430s/variants/t430s/gpio.c
M src/mainboard/lenovo/t430s/variants/t431s/gpio.c
M src/mainboard/lenovo/t440p/gpio.c
M src/mainboard/lenovo/t520/variants/t520/gpio.c
M src/mainboard/lenovo/t520/variants/w520/gpio.c
M src/mainboard/lenovo/t530/variants/t530/gpio.c
M src/mainboard/lenovo/t530/variants/w530/gpio.c
M src/mainboard/lenovo/x1_carbon_gen1/gpio.c
M src/mainboard/lenovo/x201/gpio.c
M src/mainboard/lenovo/x220/variants/x1/gpio.c
M src/mainboard/lenovo/x220/variants/x220/gpio.c
M src/mainboard/lenovo/x230/gpio.c
M src/mainboard/msi/ms7707/gpio.c
M src/mainboard/roda/rv11/gpio.c
M src/mainboard/samsung/lumpy/gpio.c
M src/mainboard/samsung/stumpy/gpio.c
M src/mainboard/sapphire/pureplatinumh61/gpio.c
44 files changed, 0 insertions(+), 2,189 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35900/4

[Peter Lemenkov (Code Review)]

Hello Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, HAOUAS Elyes, Angel Pons, Arthur Heymans, Tristan Corrick, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35900

to look at the new patch set (#5).

Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................

mb/*/*/gpio: Remove null-initialized members

Made with this oneliner:

$ find src/mainboard/  -type f -name gpio.c -print -exec sed -i -e '/^\s*.gpio[0-9]+\s*=\s*(GPIO_MODE_NATIVE|GPIO_NO_INVERT|GPIO_NO_BLINK|GPIO_RESET_PWROK),\s*$/d' {} ;

It didn't touch lines with comments since they might be useful.

See also commit 6752b6151 with Change-Id
I4e07bd755ca4a65b76c69625d235a879fe7b43cb.

Change-Id: I2799293585bcfcf41c93a9dbe358cd806f9374f5
Signed-off-by: Peter Lemenkov 
---
M src/mainboard/apple/macbookair4_2/gpio.c
M src/mainboard/asrock/b75pro3-m/gpio.c
M src/mainboard/asus/h61m-cs/gpio.c
M src/mainboard/asus/p5gc-mx/gpio.c
M src/mainboard/asus/p5qpl-am/variants/p5g41t-m_lx/gpio.c
M src/mainboard/asus/p8h61-m_pro/gpio.c
M src/mainboard/asus/p8z77-m_pro/gpio.c
M src/mainboard/compulab/intense_pc/gpio.c
M src/mainboard/foxconn/d41s/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3h/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/gpio.c
M src/mainboard/hp/2570p/gpio.c
M src/mainboard/hp/2760p/gpio.c
M src/mainboard/hp/8460p/gpio.c
M src/mainboard/hp/8470p/gpio.c
M src/mainboard/hp/8770w/gpio.c
M src/mainboard/hp/compaq_8200_elite_sff/gpio.c
M src/mainboard/hp/folio_9470m/gpio.c
M src/mainboard/hp/revolve_810_g1/gpio.c
M src/mainboard/hp/z220_sff_workstation/gpio.c
M src/mainboard/intel/dcp847ske/gpio.c
M src/mainboard/lenovo/s230u/gpio.c
M src/mainboard/lenovo/t410/gpio.c
M src/mainboard/lenovo/t420/gpio.c
M src/mainboard/lenovo/t420s/gpio.c
M src/mainboard/lenovo/t430s/variants/t430s/gpio.c
M src/mainboard/lenovo/t430s/variants/t431s/gpio.c
M src/mainboard/lenovo/t440p/gpio.c
M src/mainboard/lenovo/t520/variants/t520/gpio.c
M src/mainboard/lenovo/t520/variants/w520/gpio.c
M src/mainboard/lenovo/t530/variants/t530/gpio.c
M src/mainboard/lenovo/t530/variants/w530/gpio.c
M src/mainboard/lenovo/x1_carbon_gen1/gpio.c
M src/mainboard/lenovo/x201/gpio.c
M src/mainboard/lenovo/x220/variants/x1/gpio.c
M src/mainboard/lenovo/x220/variants/x220/gpio.c
M src/mainboard/lenovo/x230/gpio.c
M src/mainboard/msi/ms7707/gpio.c
M src/mainboard/roda/rv11/gpio.c
M src/mainboard/samsung/lumpy/gpio.c
M src/mainboard/samsung/stumpy/gpio.c
M src/mainboard/sapphire/pureplatinumh61/gpio.c
45 files changed, 0 insertions(+), 2,233 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35900/5

[Peter Lemenkov (Code Review)]

Hello Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, HAOUAS Elyes, Angel Pons, Arthur Heymans, Tristan Corrick, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35900

to look at the new patch set (#6).

Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................

mb/*/*/gpio: Remove null-initialized members

Made with this oneliner:

$ find src/mainboard/  -type f -name gpio.c -print -exec sed -i -e '/^\s*.gpio[0-9]+\s*=\s*(GPIO_MODE_NATIVE|GPIO_NO_INVERT|GPIO_NO_BLINK|GPIO_RESET_PWROK),\s*$/d' {} ;

It didn't touch lines with comments since they might be useful.

See also commit 6752b6151 with Change-Id
I4e07bd755ca4a65b76c69625d235a879fe7b43cb.

Change-Id: I2799293585bcfcf41c93a9dbe358cd806f9374f5
Signed-off-by: Peter Lemenkov 
---
M src/mainboard/apple/macbookair4_2/gpio.c
M src/mainboard/asrock/b75pro3-m/gpio.c
M src/mainboard/asus/h61m-cs/gpio.c
M src/mainboard/asus/p5gc-mx/gpio.c
M src/mainboard/asus/p5qpl-am/variants/p5g41t-m_lx/gpio.c
M src/mainboard/asus/p8h61-m_pro/gpio.c
M src/mainboard/asus/p8z77-m_pro/gpio.c
M src/mainboard/compulab/intense_pc/gpio.c
M src/mainboard/foxconn/d41s/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3h/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/gpio.c
M src/mainboard/hp/compaq_8200_elite_sff/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/2570p/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/2760p/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/8460p/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/8470p/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/8770w/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/gpio.c
M src/mainboard/hp/z220_sff_workstation/gpio.c
M src/mainboard/intel/dcp847ske/gpio.c
M src/mainboard/lenovo/s230u/gpio.c
M src/mainboard/lenovo/t410/gpio.c
M src/mainboard/lenovo/t420/gpio.c
M src/mainboard/lenovo/t420s/gpio.c
M src/mainboard/lenovo/t430s/variants/t430s/gpio.c
M src/mainboard/lenovo/t430s/variants/t431s/gpio.c
M src/mainboard/lenovo/t440p/gpio.c
M src/mainboard/lenovo/t520/variants/t520/gpio.c
M src/mainboard/lenovo/t520/variants/w520/gpio.c
M src/mainboard/lenovo/t530/variants/t530/gpio.c
M src/mainboard/lenovo/t530/variants/w530/gpio.c
M src/mainboard/lenovo/x1_carbon_gen1/gpio.c
M src/mainboard/lenovo/x201/gpio.c
M src/mainboard/lenovo/x220/variants/x1/gpio.c
M src/mainboard/lenovo/x220/variants/x220/gpio.c
M src/mainboard/lenovo/x230/gpio.c
M src/mainboard/msi/ms7707/gpio.c
M src/mainboard/roda/rv11/gpio.c
M src/mainboard/samsung/lumpy/gpio.c
M src/mainboard/samsung/stumpy/gpio.c
M src/mainboard/sapphire/pureplatinumh61/gpio.c
45 files changed, 0 insertions(+), 2,233 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35900/6

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35900 )

Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................

Patch Set 6:

Personally, I prefer explicitly stating that a GPIO is configured in native mode.

[Peter Lemenkov (Code Review)]

Hello build bot (Jenkins), Tristan Corrick, Paul Menzel, Angel Pons, Arthur Heymans, Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35900

to look at the new patch set (#7).

Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................

mb/*/*/gpio: Remove null-initialized members

Made with this oneliner:

$ find src/mainboard/  -type f -name gpio.c -print -exec sed -i -e '/^\s*.gpio[0-9]+\s*=\s*(GPIO_MODE_NATIVE|GPIO_NO_INVERT|GPIO_NO_BLINK|GPIO_RESET_PWROK),\s*$/d' {} ;

It didn't touch lines with comments since they might be useful.

See also commit 6752b6151 with Change-Id
I4e07bd755ca4a65b76c69625d235a879fe7b43cb.

Change-Id: I2799293585bcfcf41c93a9dbe358cd806f9374f5
Signed-off-by: Peter Lemenkov 
---
M src/mainboard/apple/macbookair4_2/gpio.c
M src/mainboard/asrock/b75pro3-m/gpio.c
M src/mainboard/asus/h61m-cs/gpio.c
M src/mainboard/asus/p5gc-mx/gpio.c
M src/mainboard/asus/p5qpl-am/variants/p5g41t-m_lx/gpio.c
M src/mainboard/asus/p8h61-m_pro/gpio.c
M src/mainboard/asus/p8z77-m_pro/gpio.c
M src/mainboard/asus/p8z77-v_lx2/gpio.c
M src/mainboard/compulab/intense_pc/gpio.c
M src/mainboard/foxconn/d41s/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3h/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/gpio.c
M src/mainboard/hp/compaq_8200_elite_sff/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/2570p/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/2760p/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/8460p/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/8470p/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/8770w/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/gpio.c
M src/mainboard/hp/z220_sff_workstation/gpio.c
M src/mainboard/intel/dcp847ske/gpio.c
M src/mainboard/lenovo/s230u/gpio.c
M src/mainboard/lenovo/t410/gpio.c
M src/mainboard/lenovo/t420/gpio.c
M src/mainboard/lenovo/t420s/gpio.c
M src/mainboard/lenovo/t430s/variants/t430s/gpio.c
M src/mainboard/lenovo/t430s/variants/t431s/gpio.c
M src/mainboard/lenovo/t440p/gpio.c
M src/mainboard/lenovo/t520/variants/t520/gpio.c
M src/mainboard/lenovo/t520/variants/w520/gpio.c
M src/mainboard/lenovo/t530/variants/t530/gpio.c
M src/mainboard/lenovo/t530/variants/w530/gpio.c
M src/mainboard/lenovo/x1_carbon_gen1/gpio.c
M src/mainboard/lenovo/x201/gpio.c
M src/mainboard/lenovo/x220/variants/x1/gpio.c
M src/mainboard/lenovo/x220/variants/x220/gpio.c
M src/mainboard/lenovo/x230/gpio.c
M src/mainboard/msi/ms7707/gpio.c
M src/mainboard/roda/rv11/gpio.c
M src/mainboard/samsung/lumpy/gpio.c
M src/mainboard/samsung/stumpy/gpio.c
M src/mainboard/sapphire/pureplatinumh61/gpio.c
47 files changed, 0 insertions(+), 2,287 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35900/7

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35900 )

Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................

Patch Set 7: Code-Review+1

[Peter Lemenkov (Code Review)]

Hello build bot (Jenkins), Tristan Corrick, Paul Menzel, Angel Pons, Arthur Heymans, Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, HAOUAS Elyes,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/35900

to look at the new patch set (#8).

Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................

mb/*/*/gpio: Remove null-initialized members

Made with this oneliner:

$ find src/mainboard/  -type f -name gpio.c -print -exec sed -i -e '/^\s*.gpio[0-9]+\s*=\s*(GPIO_MODE_NATIVE|GPIO_NO_INVERT|GPIO_NO_BLINK|GPIO_RESET_PWROK),\s*$/d' {} ;

It didn't touch lines with comments since they might be useful.

See also commit 6752b6151 with Change-Id
I4e07bd755ca4a65b76c69625d235a879fe7b43cb.

Change-Id: I2799293585bcfcf41c93a9dbe358cd806f9374f5
Signed-off-by: Peter Lemenkov 
---
M src/mainboard/apple/macbookair4_2/gpio.c
M src/mainboard/asrock/b75pro3-m/gpio.c
M src/mainboard/asrock/b85m_pro4/gpio.c
M src/mainboard/asus/h61m-cs/gpio.c
M src/mainboard/asus/p5gc-mx/gpio.c
M src/mainboard/asus/p5qpl-am/variants/p5g41t-m_lx/gpio.c
M src/mainboard/asus/p8h61-m_pro/gpio.c
M src/mainboard/asus/p8z77-m_pro/gpio.c
M src/mainboard/asus/p8z77-v_lx2/gpio.c
M src/mainboard/compulab/intense_pc/gpio.c
M src/mainboard/foxconn/d41s/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75-d3v/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3h/gpio.c
M src/mainboard/gigabyte/ga-b75m-d3h/variants/ga-b75m-d3v/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-ds2v/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61m-s2pv/gpio.c
M src/mainboard/gigabyte/ga-h61m-s2pv/variants/ga-h61ma-d3v/gpio.c
M src/mainboard/hp/compaq_8200_elite_sff/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/2570p/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/2760p/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/8460p/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/8470p/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/8770w/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/folio_9470m/gpio.c
M src/mainboard/hp/snb_ivb_laptops/variants/revolve_810_g1/gpio.c
M src/mainboard/hp/z220_sff_workstation/gpio.c
M src/mainboard/intel/dcp847ske/gpio.c
M src/mainboard/lenovo/s230u/gpio.c
M src/mainboard/lenovo/t410/gpio.c
M src/mainboard/lenovo/t420/gpio.c
M src/mainboard/lenovo/t420s/gpio.c
M src/mainboard/lenovo/t430s/variants/t430s/gpio.c
M src/mainboard/lenovo/t430s/variants/t431s/gpio.c
M src/mainboard/lenovo/t440p/gpio.c
M src/mainboard/lenovo/t520/variants/t520/gpio.c
M src/mainboard/lenovo/t520/variants/w520/gpio.c
M src/mainboard/lenovo/t530/variants/t530/gpio.c
M src/mainboard/lenovo/t530/variants/w530/gpio.c
M src/mainboard/lenovo/x1_carbon_gen1/gpio.c
M src/mainboard/lenovo/x201/gpio.c
M src/mainboard/lenovo/x220/variants/x1/gpio.c
M src/mainboard/lenovo/x220/variants/x220/gpio.c
M src/mainboard/lenovo/x230/gpio.c
M src/mainboard/msi/ms7707/gpio.c
M src/mainboard/roda/rv11/gpio.c
M src/mainboard/samsung/lumpy/gpio.c
M src/mainboard/samsung/stumpy/gpio.c
M src/mainboard/sapphire/pureplatinumh61/gpio.c
48 files changed, 0 insertions(+), 2,334 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/35900/8